public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: C Howland <cc1964t@gmail.com>
To: newlib@sourceware.org
Subject: Re: Fw: [PATCH] Enable automake silent rules
Date: Tue, 7 Dec 2021 15:03:12 -0500	[thread overview]
Message-ID: <CANk6obSqf85g5poDKH8ARLX4nkZ9egjRN50WygTRyZa3-6J6Lg@mail.gmail.com> (raw)
In-Reply-To: <Ya+7YQ0Oof+aSh9y@vapier>

On Tue, 7 Dec 2021 at 14:51, Mike Frysinger <vapier@gentoo.org> wrote:

> On 07 Dec 2021 11:10, C Howland wrote:
> >      Should this really be made the new default?
>
> yes
>
> >  I personally don't want it as a default because I want to see
> > command line arguments.  Easy for me to get different, but only knowing
> > how.  That leads to the next question.
>
> then use the standard `make V=1` or `./configure --disable-silent-rules`
>
> >      Given that silent were made default, it is a big change in terms of
> > what people see.  How would you know to change it?  (New feature, most
> > people are far from experts in automake.)  Therefore, the directions most
> > definitely would need something added that explains it.  (Without knowing
> > about it, I can see it taking someone a long time to chase down why they
> > suddenly lost the make output.)  Something along the lines of Jon's
> > explanation in the patch email needs to end up in README and probably
> also
> > printed by a configure help.
>
> you can make this argument about any change.  we shouldn't be paralyzed by
> historical behavior and never make progress.  the automake manual provides
> background info about why chatty make is not a good thing.
>
I did not at all say that we should not do it.  I just pointed out there
are reasons some people might not want it as the new default, while
acknowledging that others might (e.g you and Corinna) and that it is a very
visible one that needs additional consideration.

> https://www.gnu.org/software/automake/manual/automake.html#Silencing-Make
>
> the option is standard in the GNU ecosystem and adoption rate is only going
> up.  it's already in the --help of configure.  no one has to know or be an
> expert in automake to find it.
>
> OK, good.  But this underscores the need to know something for a change
for such a large impact.  (Why would one look under configure when make
output has a very large change?)

> adding the option to the newlib/README sounds reasonable since it already
> has a bunch of these.  want to send a patch ?
> -mike
>

The whole point of my response is that a README entry should be part of the
patch to begin with--you should be supplying it. (I didn't know about the
help in configure, what else would I miss?)
Craig

  reply	other threads:[~2021-12-07 20:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07 12:56 Jon Turney
2021-12-07 14:16 ` Corinna Vinschen
     [not found]   ` <DM3P110MB05226CEB561AD8A4639848CD9A6E9@DM3P110MB0522.NAMP110.PROD.OUTLOOK.COM>
2021-12-07 16:10     ` Fw: " C Howland
2021-12-07 19:52       ` Mike Frysinger
2021-12-07 20:03         ` C Howland [this message]
2021-12-08  6:26           ` Brian Inglis
2021-12-07 20:12       ` Jon Turney
2021-12-08  9:49         ` Corinna Vinschen
     [not found]           ` <DM3P110MB05226D9DD3776B639F45F2599A6F9@DM3P110MB0522.NAMP110.PROD.OUTLOOK.COM>
2021-12-08 15:41             ` Fw: " C Howland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANk6obSqf85g5poDKH8ARLX4nkZ9egjRN50WygTRyZa3-6J6Lg@mail.gmail.com \
    --to=cc1964t@gmail.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).