public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
* A patch with a small typo fix
@ 2022-12-15 20:02 Nadav
  2022-12-16 17:19 ` Jeff Johnston
  0 siblings, 1 reply; 2+ messages in thread
From: Nadav @ 2022-12-15 20:02 UTC (permalink / raw)
  To: newlib


[-- Attachment #1.1: Type: text/plain, Size: 93 bytes --]

Hi folks,

I attached a patch with a small typo fix in one of the comments of expf().

Nadav

[-- Attachment #2: 0001-e_exp-Fix-a-typo-in-the-comment.patch --]
[-- Type: text/x-patch, Size: 1293 bytes --]

From 36d4bbb7369b3091dcd200286d7b026e1e1a1b90 Mon Sep 17 00:00:00 2001
From: Nadav Rotem <nadavrot@users.noreply.github.com>
Date: Wed, 14 Dec 2022 19:53:47 -0800
Subject: [PATCH] [e_exp] Fix a typo in the comment.

The implementation of expf() explains how approximation in the range [0 - 0.34] is done. The comment describes the "Reme" algorithm for constructing the polynomial. This is a typo and should be the "Remez" algorithm. The remez algorithm (or minimax) is used to calculate the coefficients of polynomials in other implementations of exp(0 and log().

See more:
https://en.wikipedia.org/wiki/Remez_algorithm
---
 newlib/libm/math/e_exp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/newlib/libm/math/e_exp.c b/newlib/libm/math/e_exp.c
index ec26c2099..77652d687 100644
--- a/newlib/libm/math/e_exp.c
+++ b/newlib/libm/math/e_exp.c
@@ -28,7 +28,7 @@
  *	the interval [0,0.34658]:
  *	Write
  *	    R(r**2) = r*(exp(r)+1)/(exp(r)-1) = 2 + r*r/6 - r**4/360 + ...
- *      We use a special Reme algorithm on [0,0.34658] to generate 
+ *      We use a special Remez algorithm on [0,0.34658] to generate 
  * 	a polynomial of degree 5 to approximate R. The maximum error 
  *	of this polynomial approximation is bounded by 2**-59. In
  *	other words,
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: A patch with a small typo fix
  2022-12-15 20:02 A patch with a small typo fix Nadav
@ 2022-12-16 17:19 ` Jeff Johnston
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Johnston @ 2022-12-16 17:19 UTC (permalink / raw)
  To: Nadav; +Cc: newlib

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

Patch applied.

Thanks,

-- Jeff J.

On Thu, Dec 15, 2022 at 3:03 PM Nadav <nadav256@gmail.com> wrote:

> Hi folks,
>
> I attached a patch with a small typo fix in one of the comments of expf().
>
> Nadav
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-12-16 17:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-15 20:02 A patch with a small typo fix Nadav
2022-12-16 17:19 ` Jeff Johnston

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).