From: Jeff Johnston <jjohnstn@redhat.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: [RFA] Fix build failure on visium & iq2000
Date: Mon, 5 Jul 2021 16:46:32 -0400 [thread overview]
Message-ID: <CAOox84sBy_VeiU2W5rBT-+L+eDnXE=igS_btBLKJZpbMtjiO=Q@mail.gmail.com> (raw)
In-Reply-To: <18957427-ae98-5e51-37e8-437ffea2419a@gmail.com>
Hi Jeff,
Go ahead if you have commit privileges. Otherwise, let me know and I'll
post it for you.
-- Jeff J.
On Fri, Jul 2, 2021 at 1:24 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
> visium and iq2000 have libgloss configure bits that reference
> target_makefile_frag, but it's never set. This leads to failures during
> the configure process and an empty libgloss/<target>/Makefile.
> Naturally bad things happen with an empty Makefile.
>
> This patch initializes target_makefile_frag for both targets in their
> configure.in files and updates the generated configure files. This
> fixes the build failures. I've been using it in my tester for about a
> week and both targets have flipped from consistently failing to
> consistently passing.
>
>
>
> * libgloss/visium/configure.in (target_makefile_frag): Define.
> * libgloss/visium/configure: Regenerated.
> * libgloss/iq2000/configure.in (target_makefile_frag): Define.
> * libgloss/iq2000/configure: Regenerated.
>
>
> OK for the trunk? I think I've still got commit privs.
>
> Jeff
>
next prev parent reply other threads:[~2021-07-05 20:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 17:23 Jeff Law
2021-07-05 20:46 ` Jeff Johnston [this message]
2021-07-06 15:15 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOox84sBy_VeiU2W5rBT-+L+eDnXE=igS_btBLKJZpbMtjiO=Q@mail.gmail.com' \
--to=jjohnstn@redhat.com \
--cc=jeffreyalaw@gmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).