From: Jeff Law <jeffreyalaw@gmail.com>
To: newlib@sourceware.org
Subject: [RFA] Fix build failure on visium & iq2000
Date: Fri, 2 Jul 2021 11:23:58 -0600 [thread overview]
Message-ID: <18957427-ae98-5e51-37e8-437ffea2419a@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
visium and iq2000 have libgloss configure bits that reference
target_makefile_frag, but it's never set. This leads to failures during
the configure process and an empty libgloss/<target>/Makefile.
Naturally bad things happen with an empty Makefile.
This patch initializes target_makefile_frag for both targets in their
configure.in files and updates the generated configure files. This
fixes the build failures. I've been using it in my tester for about a
week and both targets have flipped from consistently failing to
consistently passing.
* libgloss/visium/configure.in (target_makefile_frag): Define.
* libgloss/visium/configure: Regenerated.
* libgloss/iq2000/configure.in (target_makefile_frag): Define.
* libgloss/iq2000/configure: Regenerated.
OK for the trunk? I think I've still got commit privs.
Jeff
[-- Attachment #2: libgloss.patch --]
[-- Type: text/plain, Size: 1683 bytes --]
diff --git a/libgloss/iq2000/configure.in b/libgloss/iq2000/configure.in
index 9cbd7e2ea..754ee3cab 100644
--- a/libgloss/iq2000/configure.in
+++ b/libgloss/iq2000/configure.in
@@ -46,6 +46,7 @@ AC_PROG_RANLIB
LIB_AM_PROG_AS
host_makefile_frag=${srcdir}/../config/default.mh
+target_makefile_frag=${srcdir}/../config/default.mt
if test "${with_multisubdir}" = "m32"; then
LD_TYPE="m32"
diff --git a/libgloss/visium/configure.in b/libgloss/visium/configure.in
index 33c1872c7..5274ba668 100644
--- a/libgloss/visium/configure.in
+++ b/libgloss/visium/configure.in
@@ -33,6 +33,7 @@ AC_PROG_RANLIB
LIB_AM_PROG_AS
host_makefile_frag=${srcdir}/../config/default.mh
+target_makefile_frag=${srcdir}/../config/default.mt
dnl We have to assign the same value to other variables because autoconf
dnl doesn't provide a mechanism to substitute a replacement keyword with
diff --git a/libgloss/iq2000/configure b/libgloss/iq2000/configure
index 66a533bc8..4411837d4 100755
--- a/libgloss/iq2000/configure
+++ b/libgloss/iq2000/configure
@@ -2520,6 +2520,7 @@ test "${CCASFLAGS+set}" = set || CCASFLAGS=$CFLAGS
host_makefile_frag=${srcdir}/../config/default.mh
+target_makefile_frag=${srcdir}/../config/default.mt
if test "${with_multisubdir}" = "m32"; then
LD_TYPE="m32"
diff --git a/libgloss/visium/configure b/libgloss/visium/configure
index f1bb39a11..abd6f5b92 100755
--- a/libgloss/visium/configure
+++ b/libgloss/visium/configure
@@ -1946,6 +1946,7 @@ test "${CCASFLAGS+set}" = set || CCASFLAGS=$CFLAGS
host_makefile_frag=${srcdir}/../config/default.mh
+target_makefile_frag=${srcdir}/../config/default.mt
host_makefile_frag_path=$host_makefile_frag
next reply other threads:[~2021-07-02 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 17:23 Jeff Law [this message]
2021-07-05 20:46 ` Jeff Johnston
2021-07-06 15:15 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18957427-ae98-5e51-37e8-437ffea2419a@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).