* [PATCH] libgloss: fix read and write prototype
@ 2024-05-05 19:16 Marc
2024-05-06 23:17 ` Jeff Johnston
0 siblings, 1 reply; 2+ messages in thread
From: Marc @ 2024-05-05 19:16 UTC (permalink / raw)
To: newlib
Use _READ_WRITE_RETURN_TYPE for read/write in libgloss/{read,write}.c to
avoid mismatching types.
Signed-off-by: Marc Poulhiès <dkm@kataplop.net>
---
Hello,
building with gcc14-rc for m68k fails with (see my mail earlier this week):
src/newlib/libgloss/m68k/../read.c:24:1: error: conflicting types for 'read'; have 'int(int, void *, size_t)' {aka 'int(int, void *, long unsigned int)'}
This simple fix makes use of _READ_WRITE_RETURN_TYPE macro to avoid mismatching types.
Marc
libgloss/read.c | 2 +-
libgloss/write.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libgloss/read.c b/libgloss/read.c
index 83a3b549b..867648278 100644
--- a/libgloss/read.c
+++ b/libgloss/read.c
@@ -20,7 +20,7 @@ extern char inbyte (void);
* read -- read bytes from the serial port. Ignore fd, since
* we only have stdin.
*/
-int
+_READ_WRITE_RETURN_TYPE
read (int fd,
void *buf_,
size_t nbytes)
diff --git a/libgloss/write.c b/libgloss/write.c
index 80bcd4a77..757141291 100644
--- a/libgloss/write.c
+++ b/libgloss/write.c
@@ -21,7 +21,7 @@ extern int outbyte (char x);
* stdout and stderr are the same. Since we have no filesystem,
* open will only return an error.
*/
-int
+_READ_WRITE_RETURN_TYPE
write (int fd,
const void *buf_,
size_t nbytes)
--
2.42.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libgloss: fix read and write prototype
2024-05-05 19:16 [PATCH] libgloss: fix read and write prototype Marc
@ 2024-05-06 23:17 ` Jeff Johnston
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Johnston @ 2024-05-06 23:17 UTC (permalink / raw)
To: Marc; +Cc: newlib
[-- Attachment #1: Type: text/plain, Size: 1626 bytes --]
Thanks Marc,
Patch applied.
-- Jeff J.
On Sun, May 5, 2024 at 3:16 PM Marc <dkm+newlib@kataplop.net> wrote:
> Use _READ_WRITE_RETURN_TYPE for read/write in libgloss/{read,write}.c to
> avoid mismatching types.
>
> Signed-off-by: Marc Poulhiès <dkm@kataplop.net>
> ---
> Hello,
>
> building with gcc14-rc for m68k fails with (see my mail earlier this week):
>
> src/newlib/libgloss/m68k/../read.c:24:1: error: conflicting types for
> 'read'; have 'int(int, void *, size_t)' {aka 'int(int, void *, long
> unsigned int)'}
>
> This simple fix makes use of _READ_WRITE_RETURN_TYPE macro to avoid
> mismatching types.
>
> Marc
>
> libgloss/read.c | 2 +-
> libgloss/write.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libgloss/read.c b/libgloss/read.c
> index 83a3b549b..867648278 100644
> --- a/libgloss/read.c
> +++ b/libgloss/read.c
> @@ -20,7 +20,7 @@ extern char inbyte (void);
> * read -- read bytes from the serial port. Ignore fd, since
> * we only have stdin.
> */
> -int
> +_READ_WRITE_RETURN_TYPE
> read (int fd,
> void *buf_,
> size_t nbytes)
> diff --git a/libgloss/write.c b/libgloss/write.c
> index 80bcd4a77..757141291 100644
> --- a/libgloss/write.c
> +++ b/libgloss/write.c
> @@ -21,7 +21,7 @@ extern int outbyte (char x);
> * stdout and stderr are the same. Since we have no filesystem,
> * open will only return an error.
> */
> -int
> +_READ_WRITE_RETURN_TYPE
> write (int fd,
> const void *buf_,
> size_t nbytes)
> --
> 2.42.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-06 23:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-05 19:16 [PATCH] libgloss: fix read and write prototype Marc
2024-05-06 23:17 ` Jeff Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).