From: Jeff Johnston <jjohnstn@redhat.com>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>
Cc: Eshan Dhawan <eshandhawan51@gmail.com>, Newlib <newlib@sourceware.org>
Subject: Re: [PATCH] Auto-generated files for commit e6ce6f1430eee503a388cf1fc7fe6634de09fb0f
Date: Tue, 9 Jun 2020 16:29:53 -0400 [thread overview]
Message-ID: <CAOox84u60C4ZUAMWy7Hcjn6UwPb8n0RWqjukmM0xhP2E+ysecQ@mail.gmail.com> (raw)
In-Reply-To: <ef6d9b11-573a-69c9-2293-382b87f64c69@embedded-brains.de>
Hi Eshan,
Typically, you do not run autotools for newllib patches. I or Corinne will
do that for you so if this patch has not changed from the one you submitted
without autoconf files, then I'll just regenerate the files for you and
amend the patch.
--- Jeff J.
On Tue, Jun 9, 2020 at 5:28 AM Sebastian Huber <
sebastian.huber@embedded-brains.de> wrote:
> On 09/06/2020 10:56, Eshan Dhawan wrote:
>
> >
> > On Tue, Jun 9, 2020 at 10:27 AM Sebastian Huber
> > <sebastian.huber@embedded-brains.de
> > <mailto:sebastian.huber@embedded-brains.de>> wrote:
> >
> > On 08/06/2020 08:06, Eshan Dhawan wrote:
> >
> > >>> On 08-Jun-2020, at 10:40 AM, Sebastian
> > Huber<sebastian.huber@embedded-brains.de
> > <mailto:sebastian.huber@embedded-brains.de>> wrote:
> > >>>
> > >>> On 07/06/2020 19:42, Eshan dhawan wrote:
> > >>>
> > >>> diff --git a/newlib/configure b/newlib/configure
> > >>> index d6c3372d8..4e0125101 100755
> > >>> --- a/newlib/configure
> > >>> +++ b/newlib/configure
> > >>> @@ -1,11 +1,9 @@
> > >>> #! /bin/sh
> > >>> # Guess values for system-dependent variables and create
> > Makefiles.
> > >>> -# Generated by GNU Autoconf 2.68 for newlib 3.3.0.
> > >>> +# Generated by GNU Autoconf 2.69 for newlib 3.3.0.
> > >>> #
> > >> If you use the wrong Autoconf/Automake versions to regenerate
> > the files, then the universe may collapse.
> > > I have tested the patches and it works completely fine with
> > these versions as well.
> >
> > With how many Newlib targets and host systems have you tested this
> > change? Are you really confident enough to change the top-level
> > configure file of Newlib through an unrelated side-effect of a
> > powerpc
> > fenv support patch?
> >
> > Please regenerate the files with the right Automake/Autoconf versions
> > and reduce the impact of your patch.
> >
> > Ok, I will regenerate the patch.
> > Could you please tell me the correct versions to be used,
> I don't know this for sure, but I guess it is Autoconf 2.68 if you look
> a couple of lines above.
>
>
next prev parent reply other threads:[~2020-06-09 20:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 17:42 Eshan dhawan
2020-06-08 5:10 ` Sebastian Huber
2020-06-08 6:06 ` Eshan Dhawan
2020-06-09 4:57 ` Sebastian Huber
[not found] ` <CAH5ZSWpJfcASW_xUosdmtUizwDiB=JRNfctZ=rcDGPdXvUMvog@mail.gmail.com>
2020-06-09 9:28 ` Sebastian Huber
2020-06-09 20:29 ` Jeff Johnston [this message]
2020-06-09 21:03 ` Eshan Dhawan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOox84u60C4ZUAMWy7Hcjn6UwPb8n0RWqjukmM0xhP2E+ysecQ@mail.gmail.com \
--to=jjohnstn@redhat.com \
--cc=eshandhawan51@gmail.com \
--cc=newlib@sourceware.org \
--cc=sebastian.huber@embedded-brains.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).