public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: Eshan Dhawan <eshandhawan51@gmail.com>
Cc: newlib@sourceware.org, joel@rtems.org, gedare@rtems.org
Subject: Re: [PATCH] Auto-generated files for commit e6ce6f1430eee503a388cf1fc7fe6634de09fb0f
Date: Tue, 9 Jun 2020 06:57:48 +0200	[thread overview]
Message-ID: <b4cfaf74-ee0d-6087-e69f-1292398a14e7@embedded-brains.de> (raw)
In-Reply-To: <7C4F403E-3A80-4C0E-AE59-02E8E153011D@gmail.com>

On 08/06/2020 08:06, Eshan Dhawan wrote:

>>> On 08-Jun-2020, at 10:40 AM, Sebastian Huber<sebastian.huber@embedded-brains.de>  wrote:
>>>
>>> On 07/06/2020 19:42, Eshan dhawan wrote:
>>>
>>> diff --git a/newlib/configure b/newlib/configure
>>> index d6c3372d8..4e0125101 100755
>>> --- a/newlib/configure
>>> +++ b/newlib/configure
>>> @@ -1,11 +1,9 @@
>>> #! /bin/sh
>>> # Guess values for system-dependent variables and create Makefiles.
>>> -# Generated by GNU Autoconf 2.68 for newlib 3.3.0.
>>> +# Generated by GNU Autoconf 2.69 for newlib 3.3.0.
>>> #
>> If you use the wrong Autoconf/Automake versions to regenerate the files, then the universe may collapse.
> I have tested the patches and it works completely fine with these versions as well.

With how many Newlib targets and host systems have you tested this 
change? Are you really confident enough to change the top-level 
configure file of Newlib through an unrelated side-effect of a powerpc 
fenv support patch?

Please regenerate the files with the right Automake/Autoconf versions 
and reduce the impact of your patch.

If you think that using Autconf 2.69 for Newlib is a good idea, then 
this should be done in a separate patch set.


  reply	other threads:[~2020-06-09  4:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-07 17:42 Eshan dhawan
2020-06-08  5:10 ` Sebastian Huber
2020-06-08  6:06   ` Eshan Dhawan
2020-06-09  4:57     ` Sebastian Huber [this message]
     [not found]       ` <CAH5ZSWpJfcASW_xUosdmtUizwDiB=JRNfctZ=rcDGPdXvUMvog@mail.gmail.com>
2020-06-09  9:28         ` Sebastian Huber
2020-06-09 20:29           ` Jeff Johnston
2020-06-09 21:03             ` Eshan Dhawan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4cfaf74-ee0d-6087-e69f-1292398a14e7@embedded-brains.de \
    --to=sebastian.huber@embedded-brains.de \
    --cc=eshandhawan51@gmail.com \
    --cc=gedare@rtems.org \
    --cc=joel@rtems.org \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).