public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Jeff Johnston <jjohnstn@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: [Patch] (1/n) newlib: Only call _fputwc_r if ELIX_LEVEL >= 4 (was: Build-dependency issues with ELIX_LEVEL)
Date: Wed, 30 Mar 2022 16:02:43 -0400	[thread overview]
Message-ID: <CAOox84uv4QB8F7iW2n+XSaGB55khAMoxo9cVgftDpnAPo9EkMg@mail.gmail.com> (raw)
In-Reply-To: <4c157ae5-3133-88da-7156-0e454e1f6535@codesourcery.com>

Hi Tobias.  This patch was merged to master.

Thanks,

-- Jeff J.

On Wed, Mar 30, 2022 at 5:44 AM Tobias Burnus <tobias@codesourcery.com>
wrote:

> Hello,
>
> this packages the the first patch of last/first email in this thread.
>
> As described in the commit log (and previous email),
> __sprint_r and __sfputs_r of (nano-)vfprintf.c
> call fputwc.c's _fputwc_r.
>
> While the vfprintf.c file is compiled for ELIX_LEVEL >= 1,
> the fputwc.c file is only compiled with ELIX_LEVEL >= 4.
>
> Solution: This patch ignores the _WIDE_ORIENT support in
> __sprint_r / __sfputs_r unless ELIX_LEVEL >= 4.
>
> It feels like the right solution but the ELIX description is
> vague enough to be not sure.
>
> Without that patch I get for ELIX_LEVEL == 1 (with nvptx)
> a link error (missing symbol) for a code calling 'fprintf'
> (with no wide char used).
>
> OK? – If so, please commit. Otherwise, comments are welcome.
>
> Tobias
> -----------------
> Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201,
> 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer:
> Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München;
> Registergericht München, HRB 106955
>

  reply	other threads:[~2022-03-30 20:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29  9:14 Build-dependency issues with ELIX_LEVEL Tobias Burnus
2022-03-30  9:43 ` [Patch] (1/n) newlib: Only call _fputwc_r if ELIX_LEVEL >= 4 (was: Build-dependency issues with ELIX_LEVEL) Tobias Burnus
2022-03-30 20:02   ` Jeff Johnston [this message]
2022-03-30 10:56 ` [Patch] (2/n) newlib: Move vasniprintf.c to ELIX 1 " Tobias Burnus
2022-04-06  5:11   ` *ping* " Tobias Burnus
2022-04-06 16:25     ` Jeff Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOox84uv4QB8F7iW2n+XSaGB55khAMoxo9cVgftDpnAPo9EkMg@mail.gmail.com \
    --to=jjohnstn@redhat.com \
    --cc=newlib@sourceware.org \
    --cc=tobias@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).