public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Jeff Johnston <jjohnstn@redhat.com>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: [PATCH] arm: Fix memchr() for Armv8-R
Date: Mon, 14 Dec 2020 16:12:56 -0500	[thread overview]
Message-ID: <CAOox84vJRG0C5Du87HY14fr-kVOv9-tgWqesW0mJeOHjNpwVHg@mail.gmail.com> (raw)
In-Reply-To: <20201204074204.31629-1-sebastian.huber@embedded-brains.de>

Patch applied to master as there were was no objection from Richard, even
though he suggests the function
needs resyncing.  If someone wants to do the resync before end-of-year,
please get approval from Richard or
Arm team.

-- Jeff J.

On Fri, Dec 4, 2020 at 2:42 AM Sebastian Huber <
sebastian.huber@embedded-brains.de> wrote:

> The Cortex-R52 processor is an Armv8-R processor with a NEON unit.  This
> fix prevents conflicting architecture profiles A/R errors issued by the
> linker.
>
> Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
> ---
>  newlib/libc/machine/arm/memchr.S | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/newlib/libc/machine/arm/memchr.S
> b/newlib/libc/machine/arm/memchr.S
> index 7c22b117e..1a4c6512c 100644
> --- a/newlib/libc/machine/arm/memchr.S
> +++ b/newlib/libc/machine/arm/memchr.S
> @@ -79,7 +79,11 @@
>
>  @ NOTE: This ifdef MUST match the one in memchr-stub.c
>  #if defined (__ARM_NEON__) || defined (__ARM_NEON)
> +#if __ARM_ARCH >= 8 && __ARM_ARCH_PROFILE == 'R'
> +       .arch   armv8-r
> +#else
>         .arch   armv7-a
> +#endif
>         .fpu    neon
>
>
> --
> 2.26.2
>
>

      parent reply	other threads:[~2020-12-14 21:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04  7:42 Sebastian Huber
2020-12-09 12:11 ` Sebastian Huber
2020-12-09 12:27   ` Richard Earnshaw
2020-12-09 12:53     ` Sebastian Huber
2020-12-14 21:12 ` Jeff Johnston [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOox84vJRG0C5Du87HY14fr-kVOv9-tgWqesW0mJeOHjNpwVHg@mail.gmail.com \
    --to=jjohnstn@redhat.com \
    --cc=newlib@sourceware.org \
    --cc=sebastian.huber@embedded-brains.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).