From: Jeff Johnston <jjohnstn@redhat.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: Newlib <newlib@sourceware.org>,
Richard Earnshaw <Richard.Earnshaw@foss.arm.com>,
"Richard.Earnshaw@arm.com" <Richard.Earnshaw@arm.com>,
Torbjorn SVENSSON <torbjorn.svensson@st.com>,
Niklas DAHLQUIST <niklas.dahlquist@st.com>
Subject: Re: [PATCH] Rerun automake in newlib/
Date: Wed, 28 Sep 2022 10:52:19 -0400 [thread overview]
Message-ID: <CAOox84vb3XX_U9RSfoUMRSVWi7eQvJajUbrHM0fg3cc_CHd6Lw@mail.gmail.com> (raw)
In-Reply-To: <20220928143253.3210378-1-szabolcs.nagy@arm.com>
[-- Attachment #1: Type: text/plain, Size: 7296 bytes --]
Patch applied, thanks.
-- Jeff J.
On Wed, Sep 28, 2022 at 10:33 AM Szabolcs Nagy <szabolcs.nagy@arm.com>
wrote:
> newlib/libc/sys/arm/Makefile.inc was modified but automake was not rerun in
>
> commit 5230eb7f8c6b43c71d7e38d138935c48de930b76
> Implement sysconf for Arm
>
> on arm-none-eabi target this caused
>
> ld: B/arm-none-eabi/lib/libg.a(libc_a-mallocr.o): in function
> `malloc_extend_top':
> S/newlib-cygwin/newlib/libc/stdlib/_mallocr.c:2161: undefined reference
> to `sysconf'
> ---
> newlib/Makefile.in | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/newlib/Makefile.in b/newlib/Makefile.in
> index f26d99ae9..d77f44560 100644
> --- a/newlib/Makefile.in
> +++ b/newlib/Makefile.in
> @@ -523,7 +523,7 @@ check_PROGRAMS =
> @HAVE_LIBC_SYS_AMDGCN_DIR_TRUE@ libc/sys/amdgcn/close.c
> libc/sys/amdgcn/fstat.c libc/sys/amdgcn/isatty.c libc/sys/amdgcn/lseek.c
> libc/sys/amdgcn/read.c libc/sys/amdgcn/write.c \
> @HAVE_LIBC_SYS_AMDGCN_DIR_TRUE@ libc/sys/amdgcn/fcntl.c
> libc/sys/amdgcn/getpid.c libc/sys/amdgcn/kill.c libc/sys/amdgcn/open.c
> libc/sys/amdgcn/raise.c libc/sys/amdgcn/stat.c libc/sys/amdgcn/unlink.c
>
> -@HAVE_LIBC_SYS_ARM_DIR_TRUE@am__append_45 = libc/sys/arm/access.c
> libc/sys/arm/aeabi_atexit.c
> +@HAVE_LIBC_SYS_ARM_DIR_TRUE@am__append_45 = libc/sys/arm/access.c
> libc/sys/arm/aeabi_atexit.c libc/sys/arm/sysconf.c
> @HAVE_LIBC_SYS_ARM_DIR_TRUE@@MAY_SUPPLY_SYSCALLS_TRUE@am__append_46 =
> libc/sys/arm/libcfunc.c libc/sys/arm/trap.S libc/sys/arm/syscalls.c
> @HAVE_LIBC_SYS_D10V_DIR_TRUE@am__append_47 = libc/sys/d10v/syscalls.c
> libc/sys/d10v/trap.S libc/sys/d10v/creat.c
> @HAVE_LIBC_SYS_EPIPHANY_DIR_TRUE@am__append_48 =
> libc/sys/epiphany/e_printf.c
> @@ -1579,7 +1579,8 @@ am__objects_51 = libc/ssp/libc_a-chk_fail.$(OBJEXT) \
> @HAVE_LIBC_SYS_AMDGCN_DIR_TRUE@
> libc/sys/amdgcn/libc_a-stat.$(OBJEXT) \
> @HAVE_LIBC_SYS_AMDGCN_DIR_TRUE@
> libc/sys/amdgcn/libc_a-unlink.$(OBJEXT)
> @HAVE_LIBC_SYS_ARM_DIR_TRUE@am__objects_55 =
> libc/sys/arm/libc_a-access.$(OBJEXT) \
> -@HAVE_LIBC_SYS_ARM_DIR_TRUE@ libc/sys/arm/libc_a-aeabi_atexit.$(OBJEXT)
> +@HAVE_LIBC_SYS_ARM_DIR_TRUE@
> libc/sys/arm/libc_a-aeabi_atexit.$(OBJEXT) \
> +@HAVE_LIBC_SYS_ARM_DIR_TRUE@ libc/sys/arm/libc_a-sysconf.$(OBJEXT)
> @HAVE_LIBC_SYS_ARM_DIR_TRUE@@MAY_SUPPLY_SYSCALLS_TRUE@am__objects_56 =
> libc/sys/arm/libc_a-libcfunc.$(OBJEXT) \
> @HAVE_LIBC_SYS_ARM_DIR_TRUE@@MAY_SUPPLY_SYSCALLS_TRUE@
> libc/sys/arm/libc_a-trap.$(OBJEXT) \
> @HAVE_LIBC_SYS_ARM_DIR_TRUE@@MAY_SUPPLY_SYSCALLS_TRUE@
> libc/sys/arm/libc_a-syscalls.$(OBJEXT)
> @@ -6802,6 +6803,8 @@ libc/sys/arm/libc_a-access.$(OBJEXT):
> libc/sys/arm/$(am__dirstamp) \
> libc/sys/arm/libc_a-aeabi_atexit.$(OBJEXT): \
> libc/sys/arm/$(am__dirstamp) \
> libc/sys/arm/$(DEPDIR)/$(am__dirstamp)
> +libc/sys/arm/libc_a-sysconf.$(OBJEXT): libc/sys/arm/$(am__dirstamp) \
> + libc/sys/arm/$(DEPDIR)/$(am__dirstamp)
> libc/sys/arm/libc_a-libcfunc.$(OBJEXT): libc/sys/arm/$(am__dirstamp) \
> libc/sys/arm/$(DEPDIR)/$(am__dirstamp)
> libc/sys/arm/libc_a-trap.$(OBJEXT): libc/sys/arm/$(am__dirstamp) \
> @@ -12833,6 +12836,7 @@ distclean-compile:
> @AMDEP_TRUE@@am__include@ @am__quote@libc
> /sys/arm/$(DEPDIR)/libc_a-aeabi_atexit.Po@am__quote@
> @AMDEP_TRUE@@am__include@ @am__quote@libc
> /sys/arm/$(DEPDIR)/libc_a-libcfunc.Po@am__quote@
> @AMDEP_TRUE@@am__include@ @am__quote@libc
> /sys/arm/$(DEPDIR)/libc_a-syscalls.Po@am__quote@
> +@AMDEP_TRUE@@am__include@ @am__quote@libc
> /sys/arm/$(DEPDIR)/libc_a-sysconf.Po@am__quote@
> @AMDEP_TRUE@@am__include@ @am__quote@libc
> /sys/arm/$(DEPDIR)/libc_a-trap.Po@am__quote@
> @AMDEP_TRUE@@am__include@ @am__quote@libc
> /sys/d10v/$(DEPDIR)/libc_a-creat.Po@am__quote@
> @AMDEP_TRUE@@am__include@ @am__quote@libc
> /sys/d10v/$(DEPDIR)/libc_a-syscalls.Po@am__quote@
> @@ -29556,6 +29560,20 @@ libc/sys/arm/libc_a-aeabi_atexit.obj:
> libc/sys/arm/aeabi_atexit.c
> @AMDEP_TRUE@@am__fastdepCC_FALSE@ DEPDIR=$(DEPDIR) $(CCDEPMODE)
> $(depcomp) @AMDEPBACKSLASH@
> @am__fastdepCC_FALSE@ $(AM_V_CC@am__nodep@)$(CC) $(DEFS)
> $(DEFAULT_INCLUDES) $(INCLUDES) $(libc_a_CPPFLAGS) $(CPPFLAGS)
> $(libc_a_CFLAGS) $(CFLAGS) -c -o libc/sys/arm/libc_a-aeabi_atexit.obj `if
> test -f 'libc/sys/arm/aeabi_atexit.c'; then $(CYGPATH_W)
> 'libc/sys/arm/aeabi_atexit.c'; else $(CYGPATH_W)
> '$(srcdir)/libc/sys/arm/aeabi_atexit.c'; fi`
>
> +libc/sys/arm/libc_a-sysconf.o: libc/sys/arm/sysconf.c
> +@am__fastdepCC_TRUE@ $(AM_V_CC)$(CC) $(DEFS) $(DEFAULT_INCLUDES)
> $(INCLUDES) $(libc_a_CPPFLAGS) $(CPPFLAGS) $(libc_a_CFLAGS) $(CFLAGS) -MT
> libc/sys/arm/libc_a-sysconf.o -MD -MP -MF
> libc/sys/arm/$(DEPDIR)/libc_a-sysconf.Tpo -c -o
> libc/sys/arm/libc_a-sysconf.o `test -f 'libc/sys/arm/sysconf.c' || echo
> '$(srcdir)/'`libc/sys/arm/sysconf.c
> +@am__fastdepCC_TRUE@ $(AM_V_at)$(am__mv)
> libc/sys/arm/$(DEPDIR)/libc_a-sysconf.Tpo
> libc/sys/arm/$(DEPDIR)/libc_a-sysconf.Po
> +@AMDEP_TRUE@@am__fastdepCC_FALSE@
> $(AM_V_CC)source='libc/sys/arm/sysconf.c'
> object='libc/sys/arm/libc_a-sysconf.o' libtool=no @AMDEPBACKSLASH@
> +@AMDEP_TRUE@@am__fastdepCC_FALSE@ DEPDIR=$(DEPDIR) $(CCDEPMODE)
> $(depcomp) @AMDEPBACKSLASH@
> +@am__fastdepCC_FALSE@ $(AM_V_CC@am__nodep@)$(CC) $(DEFS)
> $(DEFAULT_INCLUDES) $(INCLUDES) $(libc_a_CPPFLAGS) $(CPPFLAGS)
> $(libc_a_CFLAGS) $(CFLAGS) -c -o libc/sys/arm/libc_a-sysconf.o `test -f
> 'libc/sys/arm/sysconf.c' || echo '$(srcdir)/'`libc/sys/arm/sysconf.c
> +
> +libc/sys/arm/libc_a-sysconf.obj: libc/sys/arm/sysconf.c
> +@am__fastdepCC_TRUE@ $(AM_V_CC)$(CC) $(DEFS) $(DEFAULT_INCLUDES)
> $(INCLUDES) $(libc_a_CPPFLAGS) $(CPPFLAGS) $(libc_a_CFLAGS) $(CFLAGS) -MT
> libc/sys/arm/libc_a-sysconf.obj -MD -MP -MF
> libc/sys/arm/$(DEPDIR)/libc_a-sysconf.Tpo -c -o
> libc/sys/arm/libc_a-sysconf.obj `if test -f 'libc/sys/arm/sysconf.c'; then
> $(CYGPATH_W) 'libc/sys/arm/sysconf.c'; else $(CYGPATH_W)
> '$(srcdir)/libc/sys/arm/sysconf.c'; fi`
> +@am__fastdepCC_TRUE@ $(AM_V_at)$(am__mv)
> libc/sys/arm/$(DEPDIR)/libc_a-sysconf.Tpo
> libc/sys/arm/$(DEPDIR)/libc_a-sysconf.Po
> +@AMDEP_TRUE@@am__fastdepCC_FALSE@
> $(AM_V_CC)source='libc/sys/arm/sysconf.c'
> object='libc/sys/arm/libc_a-sysconf.obj' libtool=no @AMDEPBACKSLASH@
> +@AMDEP_TRUE@@am__fastdepCC_FALSE@ DEPDIR=$(DEPDIR) $(CCDEPMODE)
> $(depcomp) @AMDEPBACKSLASH@
> +@am__fastdepCC_FALSE@ $(AM_V_CC@am__nodep@)$(CC) $(DEFS)
> $(DEFAULT_INCLUDES) $(INCLUDES) $(libc_a_CPPFLAGS) $(CPPFLAGS)
> $(libc_a_CFLAGS) $(CFLAGS) -c -o libc/sys/arm/libc_a-sysconf.obj `if test
> -f 'libc/sys/arm/sysconf.c'; then $(CYGPATH_W) 'libc/sys/arm/sysconf.c';
> else $(CYGPATH_W) '$(srcdir)/libc/sys/arm/sysconf.c'; fi`
> +
> libc/sys/arm/libc_a-libcfunc.o: libc/sys/arm/libcfunc.c
> @am__fastdepCC_TRUE@ $(AM_V_CC)$(CC) $(DEFS) $(DEFAULT_INCLUDES)
> $(INCLUDES) $(libc_a_CPPFLAGS) $(CPPFLAGS) $(libc_a_CFLAGS) $(CFLAGS) -MT
> libc/sys/arm/libc_a-libcfunc.o -MD -MP -MF
> libc/sys/arm/$(DEPDIR)/libc_a-libcfunc.Tpo -c -o
> libc/sys/arm/libc_a-libcfunc.o `test -f 'libc/sys/arm/libcfunc.c' || echo
> '$(srcdir)/'`libc/sys/arm/libcfunc.c
> @am__fastdepCC_TRUE@ $(AM_V_at)$(am__mv)
> libc/sys/arm/$(DEPDIR)/libc_a-libcfunc.Tpo
> libc/sys/arm/$(DEPDIR)/libc_a-libcfunc.Po
> --
> 2.25.1
>
>
prev parent reply other threads:[~2022-09-28 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 14:32 Szabolcs Nagy
2022-09-28 14:52 ` Jeff Johnston [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOox84vb3XX_U9RSfoUMRSVWi7eQvJajUbrHM0fg3cc_CHd6Lw@mail.gmail.com \
--to=jjohnstn@redhat.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Richard.Earnshaw@foss.arm.com \
--cc=newlib@sourceware.org \
--cc=niklas.dahlquist@st.com \
--cc=szabolcs.nagy@arm.com \
--cc=torbjorn.svensson@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).