public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
* newlib: fix sys headers installation path
@ 2023-09-11 12:44 Alexey Lapshin
  2023-09-11 12:45 ` Alexey Lapshin
  0 siblings, 1 reply; 9+ messages in thread
From: Alexey Lapshin @ 2023-09-11 12:44 UTC (permalink / raw)
  To: newlib; +Cc: jjohnstn, sebastian.huber

---
 newlib/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/newlib/Makefile.am b/newlib/Makefile.am
index e29607ccd..47f0be288 100644
--- a/newlib/Makefile.am
+++ b/newlib/Makefile.am
@@ -334,7 +334,7 @@ install-data-local: install-toollibLIBRARIES install-multi $(INSTALL_DATA_LOCAL)
 	    else true; fi ; \
 	  done ; \
 	  for i in $(call rwildcard,$(srcdir)/libc/sys/$(sys_dir)/include/,*.h); do \
-	    f=`echo $$i | sed s:^$(srcdir)/libc/sys/$(sys_dir)/include/::`; \
+	    f=`echo $$i | sed s:^$(srcdir)/libc/sys/$(sys_dir)/::`; \
 	    $(MKDIR_P) $(DESTDIR)$(tooldir)/`dirname $$f`; \
 	    $(INSTALL_DATA) $$i $(DESTDIR)$(tooldir)/`dirname $$f`; \
 	  done ; \
-- 
2.34.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: newlib: fix sys headers installation path
  2023-09-11 12:44 newlib: fix sys headers installation path Alexey Lapshin
@ 2023-09-11 12:45 ` Alexey Lapshin
  2023-09-11 12:53   ` [PATCH v2] " Alexey Lapshin
  0 siblings, 1 reply; 9+ messages in thread
From: Alexey Lapshin @ 2023-09-11 12:45 UTC (permalink / raw)
  To: sebastian.huber; +Cc: jjohnstn, newlib

Hi Sebastian,

Could you please confirm that issue fixed?

Regards,
Alexey

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v2] newlib: fix sys headers installation path
  2023-09-11 12:45 ` Alexey Lapshin
@ 2023-09-11 12:53   ` Alexey Lapshin
  2023-09-11 13:09     ` Sebastian Huber
  0 siblings, 1 reply; 9+ messages in thread
From: Alexey Lapshin @ 2023-09-11 12:53 UTC (permalink / raw)
  To: sebastian.huber; +Cc: jjohnstn, newlib

---
 newlib/Makefile.am | 2 +-
 newlib/Makefile.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/newlib/Makefile.am b/newlib/Makefile.am
index e29607ccd..47f0be288 100644
--- a/newlib/Makefile.am
+++ b/newlib/Makefile.am
@@ -334,7 +334,7 @@ install-data-local: install-toollibLIBRARIES install-multi $(INSTALL_DATA_LOCAL)
 	    else true; fi ; \
 	  done ; \
 	  for i in $(call rwildcard,$(srcdir)/libc/sys/$(sys_dir)/include/,*.h); do \
-	    f=`echo $$i | sed s:^$(srcdir)/libc/sys/$(sys_dir)/include/::`; \
+	    f=`echo $$i | sed s:^$(srcdir)/libc/sys/$(sys_dir)/::`; \
 	    $(MKDIR_P) $(DESTDIR)$(tooldir)/`dirname $$f`; \
 	    $(INSTALL_DATA) $$i $(DESTDIR)$(tooldir)/`dirname $$f`; \
 	  done ; \
diff --git a/newlib/Makefile.in b/newlib/Makefile.in
index c3052acb9..5dc9dcc8d 100644
--- a/newlib/Makefile.in
+++ b/newlib/Makefile.in
@@ -50500,7 +50500,7 @@ install-data-local: install-toollibLIBRARIES install-multi $(INSTALL_DATA_LOCAL)
 	    else true; fi ; \
 	  done ; \
 	  for i in $(call rwildcard,$(srcdir)/libc/sys/$(sys_dir)/include/,*.h); do \
-	    f=`echo $$i | sed s:^$(srcdir)/libc/sys/$(sys_dir)/include/::`; \
+	    f=`echo $$i | sed s:^$(srcdir)/libc/sys/$(sys_dir)/::`; \
 	    $(MKDIR_P) $(DESTDIR)$(tooldir)/`dirname $$f`; \
 	    $(INSTALL_DATA) $$i $(DESTDIR)$(tooldir)/`dirname $$f`; \
 	  done ; \
-- 
2.34.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] newlib: fix sys headers installation path
  2023-09-11 12:53   ` [PATCH v2] " Alexey Lapshin
@ 2023-09-11 13:09     ` Sebastian Huber
  2023-09-11 13:26       ` Alexey Lapshin
  0 siblings, 1 reply; 9+ messages in thread
From: Sebastian Huber @ 2023-09-11 13:09 UTC (permalink / raw)
  To: Alexey Lapshin; +Cc: jjohnstn, newlib

On 11.09.23 14:53, Alexey Lapshin wrote:
> ---
>   newlib/Makefile.am | 2 +-
>   newlib/Makefile.in | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/newlib/Makefile.am b/newlib/Makefile.am
> index e29607ccd..47f0be288 100644
> --- a/newlib/Makefile.am
> +++ b/newlib/Makefile.am
> @@ -334,7 +334,7 @@ install-data-local: install-toollibLIBRARIES install-multi $(INSTALL_DATA_LOCAL)
>   	    else true; fi ; \
>   	  done ; \
>   	  for i in $(call rwildcard,$(srcdir)/libc/sys/$(sys_dir)/include/,*.h); do \
> -	    f=`echo $$i | sed s:^$(srcdir)/libc/sys/$(sys_dir)/include/::`; \
> +	    f=`echo $$i | sed s:^$(srcdir)/libc/sys/$(sys_dir)/::`; \
>   	    $(MKDIR_P) $(DESTDIR)$(tooldir)/`dirname $$f`; \
>   	    $(INSTALL_DATA) $$i $(DESTDIR)$(tooldir)/`dirname $$f`; \
>   	  done ; \
> diff --git a/newlib/Makefile.in b/newlib/Makefile.in
> index c3052acb9..5dc9dcc8d 100644
> --- a/newlib/Makefile.in
> +++ b/newlib/Makefile.in
> @@ -50500,7 +50500,7 @@ install-data-local: install-toollibLIBRARIES install-multi $(INSTALL_DATA_LOCAL)
>   	    else true; fi ; \
>   	  done ; \
>   	  for i in $(call rwildcard,$(srcdir)/libc/sys/$(sys_dir)/include/,*.h); do \
> -	    f=`echo $$i | sed s:^$(srcdir)/libc/sys/$(sys_dir)/include/::`; \
> +	    f=`echo $$i | sed s:^$(srcdir)/libc/sys/$(sys_dir)/::`; \
>   	    $(MKDIR_P) $(DESTDIR)$(tooldir)/`dirname $$f`; \
>   	    $(INSTALL_DATA) $$i $(DESTDIR)$(tooldir)/`dirname $$f`; \
>   	  done ; \

This patch fixes the header install problem for RTEMS. Why did the 
xtensa port work without this fix? This seems to be a generic issue.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] newlib: fix sys headers installation path
  2023-09-11 13:09     ` Sebastian Huber
@ 2023-09-11 13:26       ` Alexey Lapshin
  2023-09-13  6:11         ` Sebastian Huber
  0 siblings, 1 reply; 9+ messages in thread
From: Alexey Lapshin @ 2023-09-11 13:26 UTC (permalink / raw)
  To: sebastian.huber; +Cc: jjohnstn, newlib

> This patch fixes the header install problem for RTEMS. Why did the
> xtensa port work without this fix? This seems to be a generic issue.


This because of files from "newlib/libc/sys/xtensa/include/" used mostly while newlib build.

While build applications used chip specific core-isa.h file.. E.g. https://github.com/espressif/esp-idf/blob/master/components/xtensa/esp32/include/xtensa/config/core-isa.h

That's the reason why I did not catch the issue.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] newlib: fix sys headers installation path
  2023-09-11 13:26       ` Alexey Lapshin
@ 2023-09-13  6:11         ` Sebastian Huber
  2023-09-13 13:37           ` Alexey Lapshin
  0 siblings, 1 reply; 9+ messages in thread
From: Sebastian Huber @ 2023-09-13  6:11 UTC (permalink / raw)
  To: Alexey Lapshin; +Cc: jjohnstn, newlib



On 11.09.23 15:26, Alexey Lapshin wrote:
>> This patch fixes the header install problem for RTEMS. Why did the
>> xtensa port work without this fix? This seems to be a generic issue.
> 
> This because of files from "newlib/libc/sys/xtensa/include/" used mostly while newlib build.
> 
> While build applications used chip specific core-isa.h file.. E.g.https://github.com/espressif/esp-idf/blob/master/components/xtensa/esp32/include/xtensa/config/core-isa.h
> 
> That's the reason why I did not catch the issue.

Thanks for the explanation. May I check in the patch?

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] newlib: fix sys headers installation path
  2023-09-13  6:11         ` Sebastian Huber
@ 2023-09-13 13:37           ` Alexey Lapshin
  2023-09-18 12:22             ` Sebastian Huber
  0 siblings, 1 reply; 9+ messages in thread
From: Alexey Lapshin @ 2023-09-13 13:37 UTC (permalink / raw)
  To: sebastian.huber; +Cc: jjohnstn, newlib

> Thanks for the explanation. May I check in the patch?

Yes, that's would be nice, thanks!

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] newlib: fix sys headers installation path
  2023-09-13 13:37           ` Alexey Lapshin
@ 2023-09-18 12:22             ` Sebastian Huber
  2023-09-18 15:47               ` Jeff Johnston
  0 siblings, 1 reply; 9+ messages in thread
From: Sebastian Huber @ 2023-09-18 12:22 UTC (permalink / raw)
  To: Alexey Lapshin; +Cc: jjohnstn, newlib

On 13.09.23 15:37, Alexey Lapshin wrote:
>> Thanks for the explanation. May I check in the patch?
> 
> Yes, that's would be nice, thanks!

I need permission from Corinna or Jeff to do this.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] newlib: fix sys headers installation path
  2023-09-18 12:22             ` Sebastian Huber
@ 2023-09-18 15:47               ` Jeff Johnston
  0 siblings, 0 replies; 9+ messages in thread
From: Jeff Johnston @ 2023-09-18 15:47 UTC (permalink / raw)
  To: Sebastian Huber; +Cc: Alexey Lapshin, newlib

[-- Attachment #1: Type: text/plain, Size: 811 bytes --]

Please go ahead.

-- Jeff J.

On Mon, Sep 18, 2023 at 8:22 AM Sebastian Huber <
sebastian.huber@embedded-brains.de> wrote:

> On 13.09.23 15:37, Alexey Lapshin wrote:
> >> Thanks for the explanation. May I check in the patch?
> >
> > Yes, that's would be nice, thanks!
>
> I need permission from Corinna or Jeff to do this.
>
> --
> embedded brains GmbH
> Herr Sebastian HUBER
> Dornierstr. 4
> 82178 Puchheim
> Germany
> email: sebastian.huber@embedded-brains.de
> phone: +49-89-18 94 741 - 16
> fax:   +49-89-18 94 741 - 08
>
> Registergericht: Amtsgericht München
> Registernummer: HRB 157899
> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
> Unsere Datenschutzerklärung finden Sie hier:
> https://embedded-brains.de/datenschutzerklaerung/
>
>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-09-18 15:48 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-11 12:44 newlib: fix sys headers installation path Alexey Lapshin
2023-09-11 12:45 ` Alexey Lapshin
2023-09-11 12:53   ` [PATCH v2] " Alexey Lapshin
2023-09-11 13:09     ` Sebastian Huber
2023-09-11 13:26       ` Alexey Lapshin
2023-09-13  6:11         ` Sebastian Huber
2023-09-13 13:37           ` Alexey Lapshin
2023-09-18 12:22             ` Sebastian Huber
2023-09-18 15:47               ` Jeff Johnston

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).