From: Tamar Christina <Tamar.Christina@arm.com>
To: "newlib@sourceware.org" <newlib@sourceware.org>
Cc: nd <nd@arm.com>, Richard Earnshaw <Richard.Earnshaw@arm.com>,
"Marcus Shawcroft" <Marcus.Shawcroft@arm.com>
Subject: [PATCH] [libgloss][AArch64] Fix link when nosys.specs is used to link
Date: Thu, 13 Jul 2017 10:52:00 -0000 [thread overview]
Message-ID: <VI1PR0801MB20313037AB7411E3EB4B8D0DFFAC0@VI1PR0801MB2031.eurprd08.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
Hi All,
This patch fixes the issue where nosys.specs is used to link.
e.g. The use of crt0 without any support for semihosting requested.
The AArch64 crt0 was missing an #ifdef for the initialise_monitor_handles
which was causing the link to fail. Sorry for missing this before.
Ok for master?
PS. I don't have commit access so if OK can someone apply?
Thanks,
Tamar
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: nosys.patch --]
[-- Type: text/x-patch; name="nosys.patch", Size: 567 bytes --]
diff --git a/libgloss/aarch64/crt0.S b/libgloss/aarch64/crt0.S
index ed4dafcb10f0b1cc999d50926c49065285c61658..cbff11a4920c92a9155fc60a14d0693cce5e38ff 100644
--- a/libgloss/aarch64/crt0.S
+++ b/libgloss/aarch64/crt0.S
@@ -144,8 +144,10 @@
sub x2, x2, x0 /* Third arg: length of block */
bl FUNCTION (memset)
+#ifdef ARM_RDI_MONITOR
/* Need to set up standard file handles */
bl FUNCTION (initialise_monitor_handles)
+#endif
/* .init and .fini sections are used to create constructors
and destructors. Here we call the _init function and arrange
next reply other threads:[~2017-07-13 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 10:52 Tamar Christina [this message]
2017-07-14 8:40 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0801MB20313037AB7411E3EB4B8D0DFFAC0@VI1PR0801MB2031.eurprd08.prod.outlook.com \
--to=tamar.christina@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=nd@arm.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).