From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] [libgloss][AArch64] Fix link when nosys.specs is used to link
Date: Fri, 14 Jul 2017 08:40:00 -0000 [thread overview]
Message-ID: <20170714084053.GA2093@calimero.vinschen.de> (raw)
In-Reply-To: <VI1PR0801MB20313037AB7411E3EB4B8D0DFFAC0@VI1PR0801MB2031.eurprd08.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
On Jul 13 10:52, Tamar Christina wrote:
> Hi All,
>
> This patch fixes the issue where nosys.specs is used to link.
> e.g. The use of crt0 without any support for semihosting requested.
>
> The AArch64 crt0 was missing an #ifdef for the initialise_monitor_handles
> which was causing the link to fail. Sorry for missing this before.
>
> Ok for master?
>
> PS. I don't have commit access so if OK can someone apply?
>
> Thanks,
> Tamar
> diff --git a/libgloss/aarch64/crt0.S b/libgloss/aarch64/crt0.S
> index ed4dafcb10f0b1cc999d50926c49065285c61658..cbff11a4920c92a9155fc60a14d0693cce5e38ff 100644
> --- a/libgloss/aarch64/crt0.S
> +++ b/libgloss/aarch64/crt0.S
> @@ -144,8 +144,10 @@
> sub x2, x2, x0 /* Third arg: length of block */
> bl FUNCTION (memset)
>
> +#ifdef ARM_RDI_MONITOR
> /* Need to set up standard file handles */
> bl FUNCTION (initialise_monitor_handles)
> +#endif
>
> /* .init and .fini sections are used to create constructors
> and destructors. Here we call the _init function and arrange
Pushed.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-07-14 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 10:52 Tamar Christina
2017-07-14 8:40 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714084053.GA2093@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).