From: Corinna Vinschen <vinschen@redhat.com>
To: Simon Cook <simon.cook@embecosm.com>
Cc: newlib@sourceware.org
Subject: Re: [PATCH] libgloss: riscv: Install machine/syscall.h
Date: Wed, 19 Oct 2022 18:14:19 +0200 [thread overview]
Message-ID: <Y1AiWxy/2TBCecVm@calimero.vinschen.de> (raw)
In-Reply-To: <9e7b18f2-4c89-00e1-0a20-471ccc59624e@embecosm.com>
Hi Simon,
On Oct 19 13:04, Simon Cook wrote:
> Hi Corinna,
>
> My understanding is Makefile.am includes riscv/Makefile.inc which is the
> only file I manually edited, the Makefile.in changes were just those made
> when I ran automake in the libgloss folder after the Makefile.inc change.
Sorry, my bad, I didn't realise that when glancing at the patch.
Still, unfortunately your patch doesn't apply. It seems whitespaces,
especially leading TABs, are broken in your patch. I suspect your
MUA is breaking things. Maybe you can check this and, if all else fails,
just attach the patch to your mail?
Thanks,
Corinna
next prev parent reply other threads:[~2022-10-19 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 19:53 Simon Cook
2022-10-19 10:47 ` Corinna Vinschen
2022-10-19 11:04 ` Simon Cook
2022-10-19 16:14 ` Corinna Vinschen [this message]
2022-10-19 19:03 ` Simon Cook
2022-10-20 14:54 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1AiWxy/2TBCecVm@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
--cc=simon.cook@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).