public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH v3] libgloss: arm: break newlib dependency
Date: Wed, 11 Jan 2023 10:14:39 +0100	[thread overview]
Message-ID: <Y759/1F0TCsV3G/V@calimero.vinschen.de> (raw)
In-Reply-To: <20230111060140.24696-1-vapier@gentoo.org>

On Jan 11 01:01, Mike Frysinger wrote:
> The libgloss port has been reaching back into newlib internals for a
> single header whose contents have been frozen for almost a decade.
> To break this backwards libgloss->newlib dependency, move the acle
> header to the srcroot include/ so everyone can use the same copy.
> ---
> v3
> - use -idirafter with srcroot
> 
>  .../arm-acle-compat.h                         |   0
>  libgloss/Makefile.am                          |   3 +
>  libgloss/Makefile.in                          |   2 +
>  libgloss/arm/Makefile.in                      |   2 -
>  libgloss/arm/arm.h                            |   2 +-
>  libgloss/config/default.mh                    |   2 +-
>  newlib/Makefile.am                            |   3 +-
>  newlib/Makefile.in                            |   4 +-
>  newlib/libc/machine/arm/aeabi_memcpy-armv7a.S |   2 +-
>  newlib/libc/machine/arm/aeabi_memmove-thumb.S |   2 +-
>  newlib/libc/machine/arm/aeabi_memset-thumb.S  |   2 +-
>  newlib/libc/machine/arm/arm_asm.h             |   2 +-
>  newlib/libc/machine/arm/machine/acle-compat.h | 182 ------------------
>  newlib/libc/machine/arm/memchr-stub.c         |   2 +-
>  newlib/libc/machine/arm/memchr.S              |   2 +-
>  newlib/libc/machine/arm/memcpy-stub.c         |   2 +-
>  newlib/libc/machine/arm/memcpy.S              |   2 +-
>  newlib/libc/machine/arm/setjmp.S              |   2 +-
>  newlib/libc/machine/arm/strcmp.S              |   2 +-
>  newlib/libc/machine/arm/strlen-armv7.S        |   2 +-
>  newlib/libc/machine/arm/strlen-thumb2-Os.S    |   2 +-
>  newlib/libc/machine/arm/strlen.S              |   2 +-
>  newlib/libc/sys/arm/arm.h                     |   2 +-
>  23 files changed, 25 insertions(+), 203 deletions(-)
>  rename newlib/libc/machine/arm/acle-compat.h => include/arm-acle-compat.h (100%)
>  delete mode 100644 newlib/libc/machine/arm/machine/acle-compat.h

LGTM.


Thanks,
Corinna


      reply	other threads:[~2023-01-11  9:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14  9:13 [PATCH] " Mike Frysinger
2022-12-19  9:34 ` Corinna Vinschen
2022-12-19 10:08 ` Richard Earnshaw
2022-12-21  1:47   ` Mike Frysinger
2022-12-21  8:24     ` Corinna Vinschen
2022-12-22 22:03       ` Mike Frysinger
2023-01-03 14:56         ` Richard Earnshaw
2023-01-04  2:04 ` Mike Frysinger
2023-01-04  2:17   ` Stefan Tauner
2023-01-04  3:06     ` Mike Frysinger
2023-01-09 10:29       ` Corinna Vinschen
2023-01-10  2:07         ` Mike Frysinger
2023-01-10  8:43           ` Corinna Vinschen
2023-01-11  6:01 ` [PATCH v3] " Mike Frysinger
2023-01-11  9:14   ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y759/1F0TCsV3G/V@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).