From: Corinna Vinschen <vinschen@redhat.com>
To: iNvEr7 <iNvEr7@protonmail.com>
Cc: "newlib@sourceware.org" <newlib@sourceware.org>,
Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
Subject: Re: [PATCH] Semihosting ctr0 typo (adr/ldr)?
Date: Wed, 17 Feb 2021 11:01:41 +0100 [thread overview]
Message-ID: <YCzphQJPQ1zuLXA3@calimero.vinschen.de> (raw)
In-Reply-To: <2SG25aQ-_EdUvM9w1kXfGjpV_I6OSbvGLA9jIuXTs51Rzc7ESf1s9rIDWF85eATSD7jtZle5D2asRAeEEwtJs5adLfOf_c-uOa3myGWT-Ys=@protonmail.com>
On Feb 16 22:56, iNvEr7 via Newlib wrote:
>
> ---
> libgloss/arm/crt0.S | 2 +-
> newlib/libc/sys/arm/crt0.S | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libgloss/arm/crt0.S b/libgloss/arm/crt0.S
> index 8490bde2f..b8bbcee18 100644
> --- a/libgloss/arm/crt0.S
> +++ b/libgloss/arm/crt0.S
> @@ -283,7 +283,7 @@
> #ifdef ARM_RDI_MONITOR
> /* Issue Angel SWI to read stack info. */
> movs r0, #AngelSWI_Reason_HeapInfo
> - adr r1, .LC0 /* Point at ptr to 4 words to receive data. */
> + ldr r1, .LC0 /* Point at ptr to 4 words to receive data. */
> #ifdef THUMB_VXM
> bkpt AngelSWI
> #elif defined(__thumb2__)
> diff --git a/newlib/libc/sys/arm/crt0.S b/newlib/libc/sys/arm/crt0.S
> index 5e677a23c..3c5771229 100644
> --- a/newlib/libc/sys/arm/crt0.S
> +++ b/newlib/libc/sys/arm/crt0.S
> @@ -270,7 +270,7 @@
> #ifdef ARM_RDI_MONITOR
> /* Issue Angel SWI to read stack info. */
> movs r0, #AngelSWI_Reason_HeapInfo
> - adr r1, .LC0 /* Point at ptr to 4 words to receive data. */
> + ldr r1, .LC0 /* Point at ptr to 4 words to receive data. */
> #ifdef THUMB_VXM
> bkpt AngelSWI
> #elif defined(__thumb2__)
> --
> 2.29.2
I'm a bit suprised that this problem hasn't been noticed for the
last 10 years. I'm not familiar with the ARM stuff at all, so maybe
somebody from ARM can chime in here?
Thanks,
Corinna
next prev parent reply other threads:[~2021-02-17 10:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 22:56 iNvEr7
2021-02-17 10:01 ` Corinna Vinschen [this message]
2021-02-17 11:22 ` Richard Earnshaw
2021-02-17 12:02 ` iNvEr7
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCzphQJPQ1zuLXA3@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=Richard.Earnshaw@foss.arm.com \
--cc=iNvEr7@protonmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).