From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] newlib: mips: delete glibc-specific logic
Date: Tue, 9 Nov 2021 12:44:29 +0100 [thread overview]
Message-ID: <YYpfHW+5FMDaSbaY@calimero.vinschen.de> (raw)
In-Reply-To: <20211109032126.3250-1-vapier@gentoo.org>
On Nov 8 22:21, Mike Frysinger wrote:
> This code looks like it's written to be copied & pasted between diff
> C libraries and relies on _LIBC only being used with glibc. This will
> break when newlib changes from _COMPILING_NEWLIB to _LIBC, so delete
> the glibc-specific logic ahead of time.
> ---
> newlib/libc/machine/mips/memcpy.S | 11 -----------
> newlib/libc/machine/mips/memset.S | 10 ----------
> newlib/libc/machine/mips/strcmp.S | 9 ---------
> 3 files changed, 30 deletions(-)
ACK, please push. There's a Cygwin patch required as well
(winsup/cygwin/tzcode/private.h) before we can change to _LIBC.
Do you want to do that or shall I?
Thanks,
Corinna
prev parent reply other threads:[~2021-11-09 11:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 3:21 Mike Frysinger
2021-11-09 11:44 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYpfHW+5FMDaSbaY@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).