From: Mike Frysinger <vapier@gentoo.org>
To: Jon Turney <jon.turney@dronecode.org.uk>
Cc: newlib@sourceware.org
Subject: Re: [PATCH] Cygwin: Conditionally build documentation
Date: Wed, 8 Dec 2021 12:47:09 -0500 [thread overview]
Message-ID: <YbDvnQLgjJyKFUEI@vapier> (raw)
In-Reply-To: <20211208150340.1344-1-jon.turney@dronecode.org.uk>
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
On 08 Dec 2021 15:03, Jon Turney wrote:
> +AC_ARG_ENABLE(doc,
> + [AS_HELP_STRING([--enable-doc], [Build documentation])],
> + enable_doc=$enableval,
> + enable_doc=yes)
the 3rd arg is redundant. you can just write ,, to use the default iirc.
> +AC_CHECK_PROGS([DOCBOOK2XTEXI], [docbook2x-texi db2x_docbook2texi])
> +AC_CHECK_PROGS([XMLTO], [xmlto])
> +
> +if test "x$enable_doc" != "xno"; then
> + if test -z "$DOCBOOK2XTEXI" || test -z "$XMLTO"; then
> + AC_MSG_ERROR([Required documentation tools not found])
> + fi
> +fi
i think AM_MISSING_PROG would be more appropriate. then you don't need
the `test` logic.
https://www.gnu.org/software/automake/manual/html_node/Public-Macros.html#index-AM_005fMISSING_005fPROG
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-12-08 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 15:03 Jon Turney
2021-12-08 15:26 ` Jon Turney
2021-12-08 17:47 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbDvnQLgjJyKFUEI@vapier \
--to=vapier@gentoo.org \
--cc=jon.turney@dronecode.org.uk \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).