Re: [PATCH] Add a script for regenerating all newlib autotools files

[Corinna Vinschen <vinschen@redhat.com>]

On Dec 10 14:14, Jon Turney wrote:
> On 10/12/2021 08:58, Corinna Vinschen wrote:
> > Hi Jon,
> > 
> > On Dec  9 21:47, Jon Turney wrote:
> > > Add a script for regenerating all newlib autotools files, applying the
> > > instructions in the 'Regenerating Configuration Files' section of the
> > > README everywhere.
> > 
> > Great idea.
> > 
> > > Running this script produces loads of errors about 'no AC_LANG_SOURCE
> > > call detected in body' from libtool.m4.  This is because that file is
> > > old.
> > > 
> > > The versions of autotools in use on newlib seem to have backslid since
> > > the README was last updated (for newlib 2.1.0 in 2013), so bring those
> > > into alignment.  I don't know why.  I'm a little skeptical that automake
> > > 1.13 was used, since that doesn't permit '--cygnus', which we use.
> > > ---
> > >   newlib/README     |  4 ++--
> > >   newlib/autogen.sh | 35 +++++++++++++++++++++++++++++++++++
> > >   2 files changed, 37 insertions(+), 2 deletions(-)
> > >   create mode 100755 newlib/autogen.sh
> > > 
> > > diff --git a/newlib/README b/newlib/README
> > > index 1c0541284..d47cccbcb 100644
> > > --- a/newlib/README
> > > +++ b/newlib/README
> > > [...]
> > > +# automake
> > > +find -name configure.ac | while read f
> > > +do
> > > +  # Exclude directories containing a configure.ac and below, so that Makefile.in
> > > +  # files are generated from the nearest directory up the tree which contains a
> > > +  # configure.ac file.
> > > +  (cd $(dirname $f) ; find -type d -execdir test -e {}/configure.ac ';' -a -not -path '.' -prune -o -name Makefile.am -printf '%P\n' | while read m
> > > +   do
> > > +    automake-1.11 -ac ${m%.*}
> > 
> > Not being an automake guru at all, but... isn't the --cygnus option missing?
> 
> That's not actually required as every Makefile.am contains 'AUTOMAKE_OPTIONS
> = cygnus'.
> 
> I am working on a patch to remove '--cygnus' (since I thought that would be
> a prerequisite of silent make until I checked which automake versions added
> it), but not finished yet...

Great, feeel free to push.


Thanks,
Corinna