[PATCH] newlib: enable automake subdir-objects in all dirs

[PATCH] newlib: enable automake subdir-objects in all dirs

[Mike Frysinger]

Currently this is only enabled in the top-level as that's the only
place where it seemed to be used.  But the libc/sys/phoenix/ dir
also uses this functionality, but fails to explicitly enable it.
Automake workedaround it, but generated warnings.  Move the option
to NEWLIB_CONFIGURE so all dirs get it automatically iff they end
up using the option.  If they don't use the option, there's no
difference to the generated code.
---
 newlib/Makefile.am                  |   2 +-
 newlib/Makefile.in                  |   2 +-
 newlib/acinclude.m4                 |   2 +-
 newlib/libc/sys/phoenix/Makefile.in | 242 ++++++++++++++++------------
 4 files changed, 141 insertions(+), 107 deletions(-)

diff --git a/newlib/Makefile.am b/newlib/Makefile.am
index b2d363863380..6a28215d3620 100644
--- a/newlib/Makefile.am
+++ b/newlib/Makefile.am
@@ -1,6 +1,6 @@
 ## Process this file with automake to generate Makefile.in
 
-AUTOMAKE_OPTIONS = dejagnu subdir-objects
+AUTOMAKE_OPTIONS = dejagnu
 ACLOCAL_AMFLAGS = -I . -I .. -I ../config
 
 # Variables that will accumulate in subdirs.
diff --git a/newlib/acinclude.m4 b/newlib/acinclude.m4
index 2500ba6df17c..bdefd963542a 100644
--- a/newlib/acinclude.m4
+++ b/newlib/acinclude.m4
@@ -120,7 +120,7 @@ AC_SUBST(newlib_basedir)
 
 AC_CANONICAL_HOST
 
-AM_INIT_AUTOMAKE([foreign no-installinfo no-dependencies no-dist no-define 1.15.1])
+AM_INIT_AUTOMAKE([foreign no-installinfo no-dependencies no-dist no-define subdir-objects 1.15.1])
 AM_MAINTAINER_MODE()
 AM_SILENT_RULES(yes)
 
-- 
2.33.0

Re: [PATCH] newlib: enable automake subdir-objects in all dirs

[Corinna Vinschen]

On Jan 17 14:02, Mike Frysinger wrote:
> Currently this is only enabled in the top-level as that's the only
> place where it seemed to be used.  But the libc/sys/phoenix/ dir
> also uses this functionality, but fails to explicitly enable it.
> Automake workedaround it, but generated warnings.  Move the option
> to NEWLIB_CONFIGURE so all dirs get it automatically iff they end
> up using the option.  If they don't use the option, there's no
> difference to the generated code.
> ---
>  newlib/Makefile.am                  |   2 +-
>  newlib/Makefile.in                  |   2 +-
>  newlib/acinclude.m4                 |   2 +-
>  newlib/libc/sys/phoenix/Makefile.in | 242 ++++++++++++++++------------
>  4 files changed, 141 insertions(+), 107 deletions(-)

Thanks, please push.

Corinna