From: Mike Frysinger <vapier@gentoo.org>
To: newlib@sourceware.org
Subject: Re: [PATCH] newlib: switch to autoconf long double wider macro
Date: Fri, 21 Jan 2022 07:39:11 -0500 [thread overview]
Message-ID: <Yeqpb+RqYl1lvBqq@vapier> (raw)
In-Reply-To: <YeqYpJCwSFxQ7kp8@calimero.vinschen.de>
[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]
On 21 Jan 2022 12:27, Corinna Vinschen wrote:
> On Jan 21 00:04, Mike Frysinger wrote:
> > Now that we require a recent version of autoconf, we can rely on this
> > macro existing. It has inverted semantics from the existing test (it
> > looks for "is wider" instead of "is equal"), so we have to invert the
> > check when creating our _LDBL_EQ_DBL.
> > ---
> > newlib/configure | 72 +++++++++++++++++++++++++++++----------------
> > newlib/configure.ac | 22 ++------------
> > newlib/newlib.hin | 4 +++
> > 3 files changed, 53 insertions(+), 45 deletions(-)
>
> Looks right to me, please push.
for posterity, i'll note that autoconf uses a different (more comprehensive)
testing method that ultimately arrives at a diff answer than what newlib is
atm. for aarch64, _LDBL_EQ_DBL is now defined when it wasn't before.
newlib today is doing:
#if DBL_MANT_DIG == LDBL_MANT_DIG && \
LDBL_MIN_EXP == DBL_MIN_EXP && \
LDBL_MAX_EXP == DBL_MAX_EXP
#define _LDBL_EQ_DBL
#else
#error "LDBL != DBL"
#endif
while autoconf is doing:
(0 < ((DBL_MAX_EXP < LDBL_MAX_EXP)
+ (DBL_MANT_DIG < LDBL_MANT_DIG)
- (LDBL_MAX_EXP < DBL_MAX_EXP)
- (LDBL_MANT_DIG < DBL_MANT_DIG)))
&& (int) LDBL_EPSILON == 0
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-01-21 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 5:04 Mike Frysinger
2022-01-21 11:27 ` Corinna Vinschen
2022-01-21 12:39 ` Mike Frysinger [this message]
2022-01-21 13:27 ` Corinna Vinschen
[not found] ` <DM3P110MB0522CE6B7AE8122C7172E18A9A5B9@DM3P110MB0522.NAMP110.PROD.OUTLOOK.COM>
2022-01-21 17:03 ` C Howland
2022-01-21 22:44 ` Mike Frysinger
2022-06-22 2:52 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yeqpb+RqYl1lvBqq@vapier \
--to=vapier@gentoo.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).