From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH 0/7] newlib: reduce number of configure scripts
Date: Tue, 25 Jan 2022 14:58:55 +0100 [thread overview]
Message-ID: <YfACH+SKdxeTxgZb@calimero.vinschen.de> (raw)
In-Reply-To: <20220123060429.16293-1-vapier@gentoo.org>
On Jan 23 01:04, Mike Frysinger wrote:
> This flattens the recursive configure logic quite a bit in the newlib
> tree. I'll let the delta speak for itself.
>
> Before:
> $ find newlib/ -name configure | wc -l
> 113
> After:
> $ find newlib/ -name configure | wc -l
> 13
>
> The strategy largely is about killing off most of the stub configure
> trampolines in the libm & libc machine/ & sys/ trees. I think of those
> 100 scripts, only 5 were doing something unique (checking preprocessor
> defines), while all the rest existed purely to generate a Makefile. If
> we move that makefile generation logic into the respective top-level
> dirs, we can kill off entire subpaths.
>
> Considering how messy the remaining libc/ sys/phoenix/ and sys/linux/
> subdirs are, and I don't use or care about those targets, I don't think
> I'll try and fold the libc/ confiugre logic any more. But in spite of
> those, I think this patch series is a pretty big win without leaving
> the status quo in a bad way.
>
> Mike Frysinger (7):
> newlib: libm: merge machine/ trampoline up a level
> newlib: libm: merge machine/ configure scripts up a level
> newlib: libc: merge machine/ trampoline up a level
> newlib: libc: merge sys/ trampoline up a level
> newlib: libc: install CRT0 straight out of subdir
> newlib: libc: merge most sys/ configure scripts up a level
> newlib: libc: merge machine/ configure scripts up a level
I tested this additionally with Cygwin as target and from what I can
tell, this looks good. Please push.
Thanks,
Corinna
prev parent reply other threads:[~2022-01-25 13:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 6:04 Mike Frysinger
2022-01-23 6:04 ` [PATCH 1/7] newlib: libm: merge machine/ trampoline up a level Mike Frysinger
2022-01-26 15:58 ` Jon Turney
2022-01-27 2:46 ` Mike Frysinger
2022-01-27 15:28 ` Jon Turney
2022-01-28 0:37 ` Mike Frysinger
2022-01-28 14:28 ` Jon Turney
2022-01-29 4:56 ` Mike Frysinger
2022-01-23 6:04 ` [PATCH 2/7] newlib: libm: merge machine/ configure scripts " Mike Frysinger
2022-01-23 6:04 ` [PATCH 3/7] newlib: libc: merge machine/ trampoline " Mike Frysinger
2022-01-23 6:04 ` [PATCH 4/7] newlib: libc: merge sys/ " Mike Frysinger
2022-01-23 6:04 ` [PATCH 5/7] newlib: libc: install CRT0 straight out of subdir Mike Frysinger
2022-01-23 6:04 ` [PATCH 6/7] newlib: libc: merge most sys/ configure scripts up a level Mike Frysinger
2022-01-31 16:08 ` Richard Earnshaw
2022-02-01 4:49 ` arm-eabi fails in libc/sys/arm/: No rule to make target 'lib_a-trap.o', needed by 'lib.a' Mike Frysinger
2022-02-03 16:49 ` Richard Earnshaw
2022-02-04 1:44 ` Mike Frysinger
2022-01-23 6:04 ` [PATCH 7/7] newlib: libc: merge machine/ configure scripts up a level Mike Frysinger
2022-01-25 13:58 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfACH+SKdxeTxgZb@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).