From: Mike Frysinger <vapier@gentoo.org>
To: Jon Turney <jon.turney@dronecode.org.uk>
Cc: "newlib@sourceware.org" <newlib@sourceware.org>
Subject: Re: [PATCH 1/7] newlib: libm: merge machine/ trampoline up a level
Date: Wed, 26 Jan 2022 21:46:32 -0500 [thread overview]
Message-ID: <YfIHiBTH4hJJf9v/@vapier> (raw)
In-Reply-To: <7aee1176-8e02-39d2-d917-9d83024fc9dc@dronecode.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]
On 26 Jan 2022 15:58, Jon Turney wrote:
> On 23/01/2022 06:04, Mike Frysinger wrote:
> > The machine/{configure,Makefile} files exist only to fan out to the
> > specific machine/$arch/ subdir. We already have all that same info
> > in the libm/ dir itself, so by moving the recursive configure and
> > make calls into it, we can cut off this logic entirely and save the
> > overhead.
> >
> > For arches that don't have a machine subdir, it means they can skip
> > the logic entirely.
>
> It looks like this (and the following commint) breaks 'man info' and
> 'make man'?
>
>
> (e.g. https://github.com/cygwin/cygwin/runs/4949106511)
blah, sorry about that. i have another series pending related to man page
unification that i've been testing with and doesn't have this issue. but
that's still under review, so i pushed this quick hack fix since my series
deletes this entire chunk of code.
-mike
--- a/newlib/libc/Makefile.am
+++ b/newlib/libc/Makefile.am
@@ -199,7 +199,7 @@ stmp-targetdep: force
rm -f tmp-targetdep.texi
targetdoc=`pwd`/tmp-targetdep.texi; \
for d in $(SUBDIRS); do \
- if test "$$d" != "."; then \
+ if test "$$d" != "." && test "$$d" != "$(LIBC_MACHINE_DIR)"; then \
(cd $$d && $(MAKE) TARGETDOC=$${targetdoc} doc) || exit 1; \
fi; \
done
@@ -218,7 +218,7 @@ libc_TEXINFOS = sigset.texi posix.texi stdio64.texi iconvset.texi \
docbook-recursive: force
for d in $(SUBDIRS); do \
- if test "$$d" != "."; then \
+ if test "$$d" != "." && test "$$d" != "$(LIBC_MACHINE_DIR)"; then \
(cd $$d && $(MAKE) docbook) || exit 1; \
fi; \
done
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-01-27 2:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 6:04 [PATCH 0/7] newlib: reduce number of configure scripts Mike Frysinger
2022-01-23 6:04 ` [PATCH 1/7] newlib: libm: merge machine/ trampoline up a level Mike Frysinger
2022-01-26 15:58 ` Jon Turney
2022-01-27 2:46 ` Mike Frysinger [this message]
2022-01-27 15:28 ` Jon Turney
2022-01-28 0:37 ` Mike Frysinger
2022-01-28 14:28 ` Jon Turney
2022-01-29 4:56 ` Mike Frysinger
2022-01-23 6:04 ` [PATCH 2/7] newlib: libm: merge machine/ configure scripts " Mike Frysinger
2022-01-23 6:04 ` [PATCH 3/7] newlib: libc: merge machine/ trampoline " Mike Frysinger
2022-01-23 6:04 ` [PATCH 4/7] newlib: libc: merge sys/ " Mike Frysinger
2022-01-23 6:04 ` [PATCH 5/7] newlib: libc: install CRT0 straight out of subdir Mike Frysinger
2022-01-23 6:04 ` [PATCH 6/7] newlib: libc: merge most sys/ configure scripts up a level Mike Frysinger
2022-01-31 16:08 ` Richard Earnshaw
2022-02-01 4:49 ` arm-eabi fails in libc/sys/arm/: No rule to make target 'lib_a-trap.o', needed by 'lib.a' Mike Frysinger
2022-02-03 16:49 ` Richard Earnshaw
2022-02-04 1:44 ` Mike Frysinger
2022-01-23 6:04 ` [PATCH 7/7] newlib: libc: merge machine/ configure scripts up a level Mike Frysinger
2022-01-25 13:58 ` [PATCH 0/7] newlib: reduce number of configure scripts Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfIHiBTH4hJJf9v/@vapier \
--to=vapier@gentoo.org \
--cc=jon.turney@dronecode.org.uk \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).