From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH 1/3] libgloss: merge epiphany & libnosys & or1k configure scripts up a level
Date: Thu, 27 Jan 2022 15:45:00 +0100 [thread overview]
Message-ID: <YfKv7GuFSJYDesDV@calimero.vinschen.de> (raw)
In-Reply-To: <YfIEKinFUnp0JMQC@vapier>
On Jan 26 21:32, Mike Frysinger wrote:
> On 26 Jan 2022 13:30, Corinna Vinschen wrote:
> > On Jan 26 04:45, Mike Frysinger wrote:
> > > These subdirs have unique configure scripts to do some compiler tests.
> > > The checks should work for all targets, so hoist them up to the top
> > > libgloss dir. This should allow us to delete these subdir configure
> > > scripts.
> >
> > For some reason this patch doesn't apply cleanly to current git master:
> >
> > Applying: libgloss: merge epiphany & libnosys & or1k configure scripts up a level
> > error: git apply: bad git-diff - inconsistent old filename on line 38
> > Patch failed at 0001 libgloss: merge epiphany & libnosys & or1k configure scripts up a level
> > [...]
>
> probably because the deletions were removed from the patch before posting
> to avoid going over the mailing list limit and make it easier to focus on
> the actual changes, not generated content.
>
> binutils/gdb allows devs to push to refs/heads/users/$USER/xxx. glibc
> allows refs/heads/$USER/xxx. should we carve out similar space here ?
> then i could push my branches there and it'd be easy for you to git
> fetch && git merge with the right state. no need to sync multiple
> e-mails to your local tree.
>
> > I'm a bit concerned that this patchset removes setting and AC_SUBST'ing
> > host_makefile_frag_path while the variable is still used by various
> > Makefile.in files...
>
> sorry, but what are you looking at ? it isn't deleting that setting.
> the top level configure script has always had (and i'm not removing):
> host_makefile_frag=${srcdir}/config/default.mh
> host_makefile_frag_path=$host_makefile_frag
> AC_SUBST(host_makefile_frag_path)
> AC_SUBST_FILE(host_makefile_frag)
>
> so when i delete libgloss/$ARCH/configure, they don't lose that setting,
> they simply get it from the top level configure instead of the $ARCH one.
> -mike
Ok, please push.
Thanks,
Corinna
prev parent reply other threads:[~2022-01-27 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 9:45 Mike Frysinger
2022-01-26 9:45 ` [PATCH 2/3] libgloss: merge subdirs that have unique makefile_frags " Mike Frysinger
2022-01-26 9:45 ` [PATCH 3/3] libgloss: move to ../config/multi.m4 for multilib logic Mike Frysinger
2022-01-26 12:30 ` [PATCH 1/3] libgloss: merge epiphany & libnosys & or1k configure scripts up a level Corinna Vinschen
2022-01-27 2:32 ` Mike Frysinger
2022-01-27 14:45 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfKv7GuFSJYDesDV@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).