public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] libgloss: Fix mkinstalldirs path
@ 2022-01-27 18:52 Dimitar Dimitrov
  2022-01-28  0:41 ` Mike Frysinger
  0 siblings, 1 reply; 2+ messages in thread
From: Dimitar Dimitrov @ 2022-01-27 18:52 UTC (permalink / raw)
  To: newlib

With the move of configure scripts out of target directories, relative
paths to top_srcdir got broken:

  /bin/sh: .../newlib/libgloss/../../mkinstalldirs: No such file or directory

Fix the PRU build by switching to srcroot relative path, as rest of targets do.

I cannot test bfin, but it appears to have the same issue.

Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
---
 libgloss/bfin/Makefile.in | 3 +--
 libgloss/pru/Makefile.in  | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/libgloss/bfin/Makefile.in b/libgloss/bfin/Makefile.in
index a8ecfaf14..305ce310d 100644
--- a/libgloss/bfin/Makefile.in
+++ b/libgloss/bfin/Makefile.in
@@ -7,7 +7,6 @@ srcdir = @srcdir@
 objdir = .
 srcroot = $(srcdir)/../..
 objroot = $(objdir)/../..
-top_srcdir = @top_srcdir@
 
 prefix = @prefix@
 exec_prefix = @exec_prefix@
@@ -30,7 +29,7 @@ MULTISUBDIR =
 
 SHELL =	/bin/sh
 
-mkinstalldirs = $(SHELL) $(top_srcdir)/../../mkinstalldirs
+mkinstalldirs = $(SHELL) $(srcroot)/mkinstalldirs
 
 CC = @CC@
 
diff --git a/libgloss/pru/Makefile.in b/libgloss/pru/Makefile.in
index 3bf9f4529..7a2f290a8 100644
--- a/libgloss/pru/Makefile.in
+++ b/libgloss/pru/Makefile.in
@@ -29,7 +29,6 @@ srcdir = @srcdir@
 objdir = .
 srcroot = $(srcdir)/../..
 objroot = $(objdir)/../..
-top_srcdir = @top_srcdir@
 
 prefix = @prefix@
 exec_prefix = @exec_prefix@
@@ -49,7 +48,7 @@ MULTISUBDIR =
 
 SHELL =	/bin/sh
 
-mkinstalldirs = $(SHELL) $(top_srcdir)/../../mkinstalldirs
+mkinstalldirs = $(SHELL) $(srcroot)/mkinstalldirs
 
 CC = @CC@
 
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] libgloss: Fix mkinstalldirs path
  2022-01-27 18:52 [PATCH] libgloss: Fix mkinstalldirs path Dimitar Dimitrov
@ 2022-01-28  0:41 ` Mike Frysinger
  0 siblings, 0 replies; 2+ messages in thread
From: Mike Frysinger @ 2022-01-28  0:41 UTC (permalink / raw)
  To: Dimitar Dimitrov; +Cc: newlib

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

On 27 Jan 2022 20:52, Dimitar Dimitrov wrote:
> With the move of configure scripts out of target directories, relative
> paths to top_srcdir got broken:
> 
>   /bin/sh: .../newlib/libgloss/../../mkinstalldirs: No such file or directory
> 
> Fix the PRU build by switching to srcroot relative path, as rest of targets do.
> 
> I cannot test bfin, but it appears to have the same issue.

thanks, i can verify Blackfin, so i pushed your fix
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-28  0:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-27 18:52 [PATCH] libgloss: Fix mkinstalldirs path Dimitar Dimitrov
2022-01-28  0:41 ` Mike Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).