* [PATCH] newlib: libc: delete crt0.o duplication
@ 2022-02-17 5:04 Mike Frysinger
2022-02-18 12:33 ` Corinna Vinschen
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2022-02-17 5:04 UTC (permalink / raw)
To: newlib
The crt0.o was handled in a subdir-by-subdir basis: it would be compiled
in one (e.g. libc/sys/$arch/), then copied up one level (libc/sys/), then
copied up another (libc/) before finally being copied & installed in the
top newlib dir. The libc/sys/ copy was cleaned up, and then the top dir
was changed to copy it directly out of the libc/sys/$arch/ dir. But the
libc/sys/ copy to libc/ was left behind. Clean that up now too.
---
newlib/libc/Makefile.am | 10 ----------
newlib/libc/Makefile.in | 14 +-------------
newlib/libc/argz/Makefile.in | 1 -
newlib/libc/configure | 7 -------
newlib/libc/configure.ac | 6 ------
newlib/libc/ctype/Makefile.in | 1 -
newlib/libc/errno/Makefile.in | 1 -
newlib/libc/iconv/Makefile.in | 1 -
newlib/libc/iconv/ccs/Makefile.in | 1 -
newlib/libc/iconv/ccs/binary/Makefile.in | 1 -
newlib/libc/iconv/ces/Makefile.in | 1 -
newlib/libc/iconv/lib/Makefile.in | 1 -
newlib/libc/locale/Makefile.in | 1 -
newlib/libc/machine/a29k/Makefile.in | 1 -
newlib/libc/machine/aarch64/Makefile.in | 1 -
newlib/libc/machine/amdgcn/Makefile.in | 1 -
newlib/libc/machine/arc/Makefile.in | 1 -
newlib/libc/machine/arm/Makefile.in | 1 -
newlib/libc/machine/bfin/Makefile.in | 1 -
newlib/libc/machine/cr16/Makefile.in | 1 -
newlib/libc/machine/cris/Makefile.in | 1 -
newlib/libc/machine/crx/Makefile.in | 1 -
newlib/libc/machine/csky/Makefile.in | 1 -
newlib/libc/machine/d10v/Makefile.in | 1 -
newlib/libc/machine/d30v/Makefile.in | 1 -
newlib/libc/machine/epiphany/Makefile.in | 1 -
newlib/libc/machine/fr30/Makefile.in | 1 -
newlib/libc/machine/frv/Makefile.in | 1 -
newlib/libc/machine/ft32/Makefile.in | 1 -
newlib/libc/machine/h8300/Makefile.in | 1 -
newlib/libc/machine/h8500/Makefile.in | 1 -
newlib/libc/machine/hppa/Makefile.in | 1 -
newlib/libc/machine/i386/Makefile.in | 1 -
newlib/libc/machine/i960/Makefile.in | 1 -
newlib/libc/machine/iq2000/Makefile.in | 1 -
newlib/libc/machine/lm32/Makefile.in | 1 -
newlib/libc/machine/m32c/Makefile.in | 1 -
newlib/libc/machine/m32r/Makefile.in | 1 -
newlib/libc/machine/m68hc11/Makefile.in | 1 -
newlib/libc/machine/m68k/Makefile.in | 1 -
newlib/libc/machine/m88k/Makefile.in | 1 -
newlib/libc/machine/mep/Makefile.in | 1 -
newlib/libc/machine/microblaze/Makefile.in | 1 -
newlib/libc/machine/mips/Makefile.in | 1 -
newlib/libc/machine/mn10200/Makefile.in | 1 -
newlib/libc/machine/mn10300/Makefile.in | 1 -
newlib/libc/machine/moxie/Makefile.in | 1 -
newlib/libc/machine/msp430/Makefile.in | 1 -
newlib/libc/machine/mt/Makefile.in | 1 -
newlib/libc/machine/nds32/Makefile.in | 1 -
newlib/libc/machine/necv70/Makefile.in | 1 -
newlib/libc/machine/nios2/Makefile.in | 1 -
newlib/libc/machine/nvptx/Makefile.in | 1 -
newlib/libc/machine/or1k/Makefile.in | 1 -
newlib/libc/machine/powerpc/Makefile.in | 1 -
newlib/libc/machine/pru/Makefile.in | 1 -
newlib/libc/machine/riscv/Makefile.in | 1 -
newlib/libc/machine/rl78/Makefile.in | 1 -
newlib/libc/machine/rx/Makefile.in | 1 -
newlib/libc/machine/sh/Makefile.in | 1 -
newlib/libc/machine/sparc/Makefile.in | 1 -
newlib/libc/machine/spu/Makefile.in | 1 -
newlib/libc/machine/tic4x/Makefile.in | 1 -
newlib/libc/machine/tic6x/Makefile.in | 1 -
newlib/libc/machine/tic80/Makefile.in | 1 -
newlib/libc/machine/v850/Makefile.in | 1 -
newlib/libc/machine/visium/Makefile.in | 1 -
newlib/libc/machine/w65/Makefile.in | 1 -
newlib/libc/machine/x86_64/Makefile.in | 1 -
newlib/libc/machine/xc16x/Makefile.in | 1 -
newlib/libc/machine/xstormy16/Makefile.in | 1 -
newlib/libc/machine/z8k/Makefile.in | 1 -
newlib/libc/misc/Makefile.in | 1 -
newlib/libc/posix/Makefile.in | 1 -
newlib/libc/reent/Makefile.in | 1 -
newlib/libc/search/Makefile.in | 1 -
newlib/libc/signal/Makefile.in | 1 -
newlib/libc/ssp/Makefile.in | 1 -
newlib/libc/stdio/Makefile.in | 1 -
newlib/libc/stdio64/Makefile.in | 1 -
newlib/libc/stdlib/Makefile.in | 1 -
newlib/libc/string/Makefile.in | 1 -
newlib/libc/sys/a29khif/Makefile.in | 1 -
newlib/libc/sys/amdgcn/Makefile.in | 1 -
newlib/libc/sys/arm/Makefile.in | 1 -
newlib/libc/sys/d10v/Makefile.in | 1 -
newlib/libc/sys/epiphany/Makefile.in | 1 -
newlib/libc/sys/h8300hms/Makefile.in | 1 -
newlib/libc/sys/h8500hms/Makefile.in | 1 -
newlib/libc/sys/m88kbug/Makefile.in | 1 -
newlib/libc/sys/mmixware/Makefile.in | 1 -
newlib/libc/sys/netware/Makefile.in | 1 -
newlib/libc/sys/or1k/Makefile.in | 1 -
newlib/libc/sys/phoenix/Makefile.in | 1 -
newlib/libc/sys/phoenix/machine/arm/Makefile.in | 1 -
newlib/libc/sys/rdos/Makefile.in | 1 -
newlib/libc/sys/rtems/Makefile.in | 1 -
newlib/libc/sys/sh/Makefile.in | 1 -
newlib/libc/sys/sysmec/Makefile.in | 1 -
newlib/libc/sys/sysnec810/Makefile.in | 1 -
newlib/libc/sys/sysnecv850/Makefile.in | 1 -
newlib/libc/sys/sysvi386/Makefile.in | 1 -
newlib/libc/sys/sysvnecv70/Makefile.in | 1 -
newlib/libc/sys/tic80/Makefile.in | 1 -
newlib/libc/sys/tirtos/Makefile.in | 1 -
newlib/libc/sys/w65/Makefile.in | 1 -
newlib/libc/sys/z8ksim/Makefile.in | 1 -
newlib/libc/syscalls/Makefile.in | 1 -
newlib/libc/time/Makefile.in | 1 -
newlib/libc/unix/Makefile.in | 1 -
newlib/libc/xdr/Makefile.in | 1 -
111 files changed, 1 insertion(+), 143 deletions(-)
diff --git a/newlib/libc/Makefile.am b/newlib/libc/Makefile.am
index 4534ea4ee0d0..658bf0ec494e 100644
--- a/newlib/libc/Makefile.am
+++ b/newlib/libc/Makefile.am
@@ -51,8 +51,6 @@ endif
# accumulation logic.
SUBDIRS += .
-noinst_DATA = $(CRT0)
-
noinst_LIBRARIES = libc.a
SUBLIBS = \
argz/lib.a \
@@ -91,13 +89,5 @@ libc.a: $(SUBLIBS)
$(SUBLIBS): ; @true
-crt0.o: sys/crt0.o
- rm -f $@
- ln sys/crt0.o $@ >/dev/null 2>/dev/null || cp sys/crt0.o $@
-
-sys/crt0.o: ; @true
-
-CLEANFILES = $(CRT0)
-
ACLOCAL_AMFLAGS = -I .. -I ../.. -I ../../config
CONFIG_STATUS_DEPENDENCIES = $(newlib_basedir)/configure.host
diff --git a/newlib/libc/configure.ac b/newlib/libc/configure.ac
index 96187da99361..3a70e2986d2c 100644
--- a/newlib/libc/configure.ac
+++ b/newlib/libc/configure.ac
@@ -49,12 +49,6 @@ NEWLIB_CONFIGURE(..)
AM_CONDITIONAL(NEWLIB_NANO_MALLOC, test x$newlib_nano_malloc = xyes)
-CRT0=
-if test "x${have_crt0}" = "xyes"; then
- CRT0=sys/${sys_dir}/crt0.o
-fi
-AC_SUBST(CRT0)
-
dnl For each directory which we may or may not want, we define a name
dnl for the library and an automake conditional for whether we should
dnl build the library.
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] newlib: libc: delete crt0.o duplication
2022-02-17 5:04 [PATCH] newlib: libc: delete crt0.o duplication Mike Frysinger
@ 2022-02-18 12:33 ` Corinna Vinschen
0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2022-02-18 12:33 UTC (permalink / raw)
To: newlib
On Feb 17 00:04, Mike Frysinger wrote:
> The crt0.o was handled in a subdir-by-subdir basis: it would be compiled
> in one (e.g. libc/sys/$arch/), then copied up one level (libc/sys/), then
> copied up another (libc/) before finally being copied & installed in the
> top newlib dir. The libc/sys/ copy was cleaned up, and then the top dir
> was changed to copy it directly out of the libc/sys/$arch/ dir. But the
> libc/sys/ copy to libc/ was left behind. Clean that up now too.
> ---
LGTM
Thx,
Corinna
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-18 12:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-17 5:04 [PATCH] newlib: libc: delete crt0.o duplication Mike Frysinger
2022-02-18 12:33 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).