From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] newlib: simplify nds32 automake checks
Date: Tue, 8 Feb 2022 10:27:19 +0100 [thread overview]
Message-ID: <YgI3dwlB43T802zy@calimero.vinschen.de> (raw)
In-Reply-To: <20220207061828.15199-1-vapier@gentoo.org>
On Feb 7 01:18, Mike Frysinger wrote:
> This code is a bit more convoluted than it needs to be. GPR_SOURCES
> is never set to anything, and the automake checks use negative logic
> to add the SP & DP source files to dedicated variables that are only
> expanded once. Get rid of the unused variable, use normal boolean
> logic, and collapse the source settings into a single variable.
> ---
> newlib/libm/machine/nds32/Makefile.am | 17 +++++++----------
> newlib/libm/machine/nds32/Makefile.in | 18 ++++++++----------
> 2 files changed, 15 insertions(+), 20 deletions(-)
LGTM
Thanks,
Corinna
prev parent reply other threads:[~2022-02-08 9:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 6:18 Mike Frysinger
2022-02-08 9:27 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgI3dwlB43T802zy@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).