public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] libgloss: m68k: rename $DO to $TARGET
Date: Wed, 9 Feb 2022 12:02:29 +0100	[thread overview]
Message-ID: <YgOfRU6qYCISmBTM@calimero.vinschen.de> (raw)
In-Reply-To: <20220209051558.28100-1-vapier@gentoo.org>

On Feb  9 00:15, Mike Frysinger wrote:
> The common $DO variable is used by the multilib logic to control which
> target to multiplex.  But the m68k subdir is also using $DO to control
> which target (m68k or fido) to build.  As we flatten things to automake,
> this conflict shows up and breaks the m68k build.  Just rename the m68k
> variable to something unique to avoid it.
> ---
>  libgloss/m68k/Makefile.in  |  6 +++---
>  libgloss/m68k/configure    | 12 ++++++------
>  libgloss/m68k/configure.ac | 10 +++++-----
>  3 files changed, 14 insertions(+), 14 deletions(-)

LGTM, please push.


Corinna


      reply	other threads:[~2022-02-09 11:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09  5:15 Mike Frysinger
2022-02-09 11:02 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgOfRU6qYCISmBTM@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).