* Recent change broke bfin-elf
@ 2022-02-11 16:06 Jeff Law
2022-02-11 22:43 ` Mike Frysinger
2022-02-12 6:36 ` [PATCH/committed] libgloss: bfin: fix local header usage after automake move Mike Frysinger
0 siblings, 2 replies; 4+ messages in thread
From: Jeff Law @ 2022-02-11 16:06 UTC (permalink / raw)
To: Mike Frysinger; +Cc: Newlib
This change:
> commit 66dfedc28778e81d9d75a4a3fa1e74192138bf62
> Author: Mike Frysinger <vapier@gentoo.org>
> Date: Wed Feb 2 01:06:21 2022 -0500
>
> libgloss: merge bfin into top-level Makefile
>
> Avoid a recursive make to speed things up a bit.
Broke the bfin-elf port with:
../../../../..//newlib-cygwin/libgloss/bfin/basiccrt.S:28:10: fatal
error: sys/platform.h: No such file or directory
28 | #include <sys/platform.h>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Recent change broke bfin-elf 2022-02-11 16:06 Recent change broke bfin-elf Jeff Law @ 2022-02-11 22:43 ` Mike Frysinger 2022-02-11 22:46 ` Jeff Law 2022-02-12 6:36 ` [PATCH/committed] libgloss: bfin: fix local header usage after automake move Mike Frysinger 1 sibling, 1 reply; 4+ messages in thread From: Mike Frysinger @ 2022-02-11 22:43 UTC (permalink / raw) To: Jeff Law; +Cc: Newlib [-- Attachment #1: Type: text/plain, Size: 772 bytes --] On 11 Feb 2022 09:06, Jeff Law wrote: > This change: > > > commit 66dfedc28778e81d9d75a4a3fa1e74192138bf62 > > Author: Mike Frysinger <vapier@gentoo.org> > > Date: Wed Feb 2 01:06:21 2022 -0500 > > > > libgloss: merge bfin into top-level Makefile > > > > Avoid a recursive make to speed things up a bit. > > Broke the bfin-elf port with: > > ../../../../..//newlib-cygwin/libgloss/bfin/basiccrt.S:28:10: fatal > error: sys/platform.h: No such file or directory > 28 | #include <sys/platform.h> bfin-elf is one i regularly test. it still builds for me. i'm guessing you're testing just binutils+gcc and don't have newlib+libgloss installed already ? that might be why mine passes ... i'm using a full toolchain. -mike [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Recent change broke bfin-elf 2022-02-11 22:43 ` Mike Frysinger @ 2022-02-11 22:46 ` Jeff Law 0 siblings, 0 replies; 4+ messages in thread From: Jeff Law @ 2022-02-11 22:46 UTC (permalink / raw) To: Newlib On 2/11/2022 3:43 PM, Mike Frysinger wrote: > On 11 Feb 2022 09:06, Jeff Law wrote: >> This change: >> >>> commit 66dfedc28778e81d9d75a4a3fa1e74192138bf62 >>> Author: Mike Frysinger <vapier@gentoo.org> >>> Date: Wed Feb 2 01:06:21 2022 -0500 >>> >>> libgloss: merge bfin into top-level Makefile >>> >>> Avoid a recursive make to speed things up a bit. >> Broke the bfin-elf port with: >> >> ../../../../..//newlib-cygwin/libgloss/bfin/basiccrt.S:28:10: fatal >> error: sys/platform.h: No such file or directory >> 28 | #include <sys/platform.h> > bfin-elf is one i regularly test. it still builds for me. > > i'm guessing you're testing just binutils+gcc and don't have newlib+libgloss > installed already ? that might be why mine passes ... i'm using a full > toolchain. Correct. It's a build from scratch with nothing pre-installed. jeff ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH/committed] libgloss: bfin: fix local header usage after automake move 2022-02-11 16:06 Recent change broke bfin-elf Jeff Law 2022-02-11 22:43 ` Mike Frysinger @ 2022-02-12 6:36 ` Mike Frysinger 1 sibling, 0 replies; 4+ messages in thread From: Mike Frysinger @ 2022-02-12 6:36 UTC (permalink / raw) To: newlib; +Cc: Jeff Law Compiling the basiccrt .S files missed an include to the local bfin/ headers causing the build to break when installing anew. Reported-by: Jeff Law <jeffreyalaw@gmail.com> --- libgloss/Makefile.in | 21 +++++++++++---------- libgloss/bfin/Makefile.inc | 22 ++++++++++++---------- 2 files changed, 23 insertions(+), 20 deletions(-) diff --git a/libgloss/bfin/Makefile.inc b/libgloss/bfin/Makefile.inc index 35e880809a0e..47ba12c064ca 100644 --- a/libgloss/bfin/Makefile.inc +++ b/libgloss/bfin/Makefile.inc @@ -1,3 +1,5 @@ +%C%_CPPFLAGS = -I$(srcdir)/%D%/include + # Here is all of the simulator stuff. multilibtool_LIBRARIES += %D%/libsim.a %C%_libsim_a_SOURCES = \ @@ -5,7 +7,7 @@ multilibtool_LIBRARIES += %D%/libsim.a %D%/syscalls.c %C%_libsim_a_CPPFLAGS = \ $(AM_CPPFLAGS) \ - -I$(srcdir)/%D/include + $(%C%_CPPFLAGS) check_PROGRAMS += %D%/sim-test @@ -51,21 +53,21 @@ multilibtool_LIBRARIES += %D%/libbfinbsp.a %D%/_exit.c %C%_libbfinbsp_a_CPPFLAGS = \ $(AM_CPPFLAGS) \ - -I$(srcdir)/%D/include + $(%C%_CPPFLAGS) %D%/basiccrt.$(OBJEXT): %D%/basiccrt.S - $(AM_V_CC)$(COMPILE) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),,-mcpu=bf532-any) + $(AM_V_CC)$(COMPILE) $(%C%_CPPFLAGS) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),,-mcpu=bf532-any) %D%/basiccrts.$(OBJEXT): %D%/basiccrt.S - $(AM_V_CC)$(COMPILE) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),,-mcpu=bf532-any) -D__BFIN_SDRAM + $(AM_V_CC)$(COMPILE) $(%C%_CPPFLAGS) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),,-mcpu=bf532-any) -D__BFIN_SDRAM %D%/basiccrt561.$(OBJEXT): %D%/basiccrt.S - $(AM_V_CC)$(COMPILE) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),-mcpu=bf561-any,-mcpu=bf561-none) + $(AM_V_CC)$(COMPILE) $(%C%_CPPFLAGS) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),-mcpu=bf561-any,-mcpu=bf561-none) %D%/basiccrt561s.$(OBJEXT): %D%/basiccrt.S - $(AM_V_CC)$(COMPILE) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),-mcpu=bf561-any,-mcpu=bf561-none) -D__BFIN_SDRAM + $(AM_V_CC)$(COMPILE) $(%C%_CPPFLAGS) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),-mcpu=bf561-any,-mcpu=bf561-none) -D__BFIN_SDRAM %D%/basiccrt561b.$(OBJEXT): %D%/basiccrt.S - $(AM_V_CC)$(COMPILE) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),-mcpu=bf561-any,-mcpu=bf561-none) -D__ADSPBF561_COREB__ + $(AM_V_CC)$(COMPILE) $(%C%_CPPFLAGS) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),-mcpu=bf561-any,-mcpu=bf561-none) -D__ADSPBF561_COREB__ %D%/basiccrt60x.$(OBJEXT): %D%/basiccrt.S - $(AM_V_CC)$(COMPILE) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),-mcpu=bf608-any,-mcpu=bf608-none) + $(AM_V_CC)$(COMPILE) $(%C%_CPPFLAGS) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),-mcpu=bf608-any,-mcpu=bf608-none) %D%/basiccrt60xs.$(OBJEXT): %D%/basiccrt.S - $(AM_V_CC)$(COMPILE) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),-mcpu=bf608-any,-mcpu=bf608-none) -D__BFIN_SDRAM + $(AM_V_CC)$(COMPILE) $(%C%_CPPFLAGS) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),-mcpu=bf608-any,-mcpu=bf608-none) -D__BFIN_SDRAM %D%/basiccrt60xc1.$(OBJEXT): %D%/basiccrt.S - $(AM_V_CC)$(COMPILE) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),-mcpu=bf608-any,-mcpu=bf608-none) -D__ADSPBF60x_CORE1__ + $(AM_V_CC)$(COMPILE) $(%C%_CPPFLAGS) -o $@ -c $< $(if $(findstring mcpu=,$(CFLAGS)),-mcpu=bf608-any,-mcpu=bf608-none) -D__ADSPBF60x_CORE1__ -- 2.34.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-12 6:36 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-02-11 16:06 Recent change broke bfin-elf Jeff Law 2022-02-11 22:43 ` Mike Frysinger 2022-02-11 22:46 ` Jeff Law 2022-02-12 6:36 ` [PATCH/committed] libgloss: bfin: fix local header usage after automake move Mike Frysinger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).