[PATCH] newlib: i386/xstormy16: drop unused -I libm/common flag

[PATCH] newlib: i386/xstormy16: drop unused -I libm/common flag

[Mike Frysinger]

These subdirs don't actually use anything from libm.  The common dir
in particular only has 4 header files, and none are included here.

The xstormy16 code has a comment mentioning why this hack is here, but
it refers to code that was removed when its configure script was merged
up a level.
---
 newlib/libc/machine/i386/Makefile.am      | 2 +-
 newlib/libc/machine/i386/Makefile.in      | 2 +-
 newlib/libc/machine/xstormy16/Makefile.am | 4 +---
 newlib/libc/machine/xstormy16/Makefile.in | 5 +----
 4 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/newlib/libc/machine/i386/Makefile.am b/newlib/libc/machine/i386/Makefile.am
index 28525ae5790b..fa1bec6ef45b 100644
--- a/newlib/libc/machine/i386/Makefile.am
+++ b/newlib/libc/machine/i386/Makefile.am
@@ -1,6 +1,6 @@
 ## Process this file with automake to generate Makefile.in
 
-AM_CPPFLAGS = -I $(abs_newlib_basedir)/libm/common $(NEWLIB_CFLAGS) $(TARGET_CFLAGS)
+AM_CPPFLAGS = $(NEWLIB_CFLAGS) $(TARGET_CFLAGS)
 
 AM_CCASFLAGS = $(AM_CPPFLAGS)
 
diff --git a/newlib/libc/machine/xstormy16/Makefile.am b/newlib/libc/machine/xstormy16/Makefile.am
index 877c59bf615a..faaac89413ed 100644
--- a/newlib/libc/machine/xstormy16/Makefile.am
+++ b/newlib/libc/machine/xstormy16/Makefile.am
@@ -1,8 +1,6 @@
 ## Process this file with automake to generate Makefile.in
 
-# hack: putting $(abs_newlib_basedir)/libm/common into AM_CPPFLAGS forces automake
-# to output a definition for newlib_basedir.
-AM_CPPFLAGS = -I $(abs_newlib_basedir)/libm/common $(NEWLIB_CFLAGS) $(TARGET_CFLAGS)
+AM_CPPFLAGS = $(NEWLIB_CFLAGS) $(TARGET_CFLAGS)
 
 AM_CCASFLAGS = $(AM_CPPFLAGS)
 
-- 
2.34.1

Re: [PATCH] newlib: i386/xstormy16: drop unused -I libm/common flag

[Corinna Vinschen]

On Feb 14 01:01, Mike Frysinger wrote:
> These subdirs don't actually use anything from libm.  The common dir
> in particular only has 4 header files, and none are included here.
> 
> The xstormy16 code has a comment mentioning why this hack is here, but
> it refers to code that was removed when its configure script was merged
> up a level.

But xstormy16 still builds?


Corinna

Re: [PATCH] newlib: i386/xstormy16: drop unused -I libm/common flag

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

On 15 Feb 2022 14:44, Corinna Vinschen wrote:
> On Feb 14 01:01, Mike Frysinger wrote:
> > These subdirs don't actually use anything from libm.  The common dir
> > in particular only has 4 header files, and none are included here.
> > 
> > The xstormy16 code has a comment mentioning why this hack is here, but
> > it refers to code that was removed when its configure script was merged
> > up a level.
> 
> But xstormy16 still builds?

it sure does
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] newlib: i386/xstormy16: drop unused -I libm/common flag

[Corinna Vinschen]

On Feb 15 11:34, Mike Frysinger wrote:
> On 15 Feb 2022 14:44, Corinna Vinschen wrote:
> > On Feb 14 01:01, Mike Frysinger wrote:
> > > These subdirs don't actually use anything from libm.  The common dir
> > > in particular only has 4 header files, and none are included here.
> > > 
> > > The xstormy16 code has a comment mentioning why this hack is here, but
> > > it refers to code that was removed when its configure script was merged
> > > up a level.
> > 
> > But xstormy16 still builds?
> 
> it sure does
> -mike

GTG then!


Thanks,
Corinna