public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] newlib: libc: move stdio multiplex logic from build to source files
Date: Mon, 28 Feb 2022 13:07:55 +0100	[thread overview]
Message-ID: <Yhy7G7SaIZbKHKv4@calimero.vinschen.de> (raw)
In-Reply-To: <20220226044748.32601-1-vapier@gentoo.org>

On Feb 25 23:47, Mike Frysinger wrote:
> Rather than define per-object rules in the Makefile, have small files
> that define & include the right content.  This simplifies the build
> rules, and makes understanding the source a little easier (imo) as it
> makes all the subdirs behave the same: you have 1 source file and it
> produces 1 object.  It's also about the same amount of boiler plate,
> without having to define custom build rules that can fall out of sync.
> Some of these rules were already unnecessary as they were compiling a
> single source file into the same named object w/out custom flags, and
> Automake handles that for us completely.
> 
> This will also be important as we merge the libc.a build into the top
> dir since it relies on a single flat list of objects for overrides.
> 
> Also take the opportunity to clean up the unnecessary header deps in
> here.  Automake provides dependency generation for free now.

That sounds like a really good idea.


Thx,
Corinna


      reply	other threads:[~2022-02-28 12:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-26  4:47 Mike Frysinger
2022-02-28 12:07 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yhy7G7SaIZbKHKv4@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).