From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] newlib: speed up targ-include setup & add error checking
Date: Mon, 28 Feb 2022 11:40:44 +0100 [thread overview]
Message-ID: <YhymrBMfSfhvp7rm@calimero.vinschen.de> (raw)
In-Reply-To: <20220226041050.23067-1-vapier@gentoo.org>
On Feb 25 23:10, Mike Frysinger wrote:
> The current targ-include setup runs `cp` and `basename` for every
> header file it installs, in serial. This can be a little noticeable
> on systems, so cleanup the logic to rely on cp's ability to copy
> multiple files to a single directory.
>
> We still need the for loop to check for empty directories with no
> headers (i.e. the glob doesn't match anything).
> ---
> newlib/Makefile.am | 84 +++++++++++------------------------------
> newlib/Makefile.in | 93 +++++++++++++---------------------------------
> 2 files changed, 47 insertions(+), 130 deletions(-)
LGTM. Please squash these two.
Thx,
Corinna
prev parent reply other threads:[~2022-02-28 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 0:27 [PATCH] newlib: simplify header setup rules Mike Frysinger
2022-02-26 4:10 ` [PATCH] newlib: speed up targ-include setup & add error checking Mike Frysinger
2022-02-26 4:50 ` Mike Frysinger
2022-02-28 10:40 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhymrBMfSfhvp7rm@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).