From: Mike Frysinger <vapier@gentoo.org>
To: newlib@sourceware.org
Subject: Re: [PATCH v2] newlib: libc: merge build up a directory
Date: Mon, 14 Mar 2022 23:15:18 -0400 [thread overview]
Message-ID: <YjAExpWFfcGnNIeI@vapier> (raw)
In-Reply-To: <20220315030437.17762-1-vapier@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 1980 bytes --]
On 14 Mar 2022 23:04, Mike Frysinger wrote:
> Convert all the libc/ subdir makes into the top-level Makefile. This
> allows us to build all of libc from the top Makefile without using any
> recursive make calls. This is faster and avoids the funky lib.a logic
> where we unpack subdir archives to repack into a single libc.a. The
> machine override logic is maintained though by way of Makefile include
> ordering, and source file accumulation in libc_a_SOURCES.
>
> There's a few dummy.c files that are no longer necessary since we aren't
> doing the lib.a accumulating, so punt them.
> ---
> v2
> - fix some bad paths & compiler settings & missing \ in stdio subdirs
i also pushed this to topic/vapier-libc if you want to fetch that to test.
i checked against these targets:
aarch64-elf arc-elf arm-eabi
bfin-elf
cr16-elf cris-elf csky-elf
epiphany-elf
frv-elf
h8300-elf
i386-elf i686-pc-cygwin iq2000-elf
lm32-elf
m68k-elf microblaze-elf mips-elf mn10300-elf moxie-elf
nds32le-elf
or1k-elf
powerpc-elf
sparc-elf sparc-rtems
v850e-elf visium-elf
x86_64-pc-cygwin xstormy16-elf
i checked the newlib object lists to make sure they matched and the
disassembly was the same between them. there were some changes, but
they were expected: no longer including dummy.o, and for some ports,
using libc_a- prefix on the objects.
cygwin newlib works, but winsup breaks because it has a direct
reference on an internal lib.a file that no longer exists:
libssp.a: $(LIB_NAME) $(newlib_build)/libc/ssp/lib.a
$(AM_V_GEN)$(speclib) $^ $(@F)
i could fix it like so:
--- a/winsup/cygwin/Makefile.am
+++ b/winsup/cygwin/Makefile.am
@@ -719,7 +719,7 @@
libacl.a: $(LIB_NAME) sec_posixacl.o
$(AM_V_GEN)$(speclib) $^ $(@F)
-libssp.a: $(LIB_NAME) $(newlib_build)/libc/ssp/lib.a
+libssp.a: $(LIB_NAME) $(wildcard $(newlib_build)/libc/ssp/*.o)
$(AM_V_GEN)$(speclib) $^ $(@F)
#
not sure what the preference is here.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-03-15 3:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 1:39 [PATCH] " Mike Frysinger
2022-03-09 8:07 ` Corinna Vinschen
2022-03-09 9:12 ` Mike Frysinger
2022-03-13 21:18 ` Mike Frysinger
2022-03-14 2:48 ` Mike Frysinger
2022-03-14 10:58 ` Corinna Vinschen
2022-03-15 0:07 ` Mike Frysinger
2022-03-15 3:04 ` [PATCH v2] " Mike Frysinger
2022-03-15 3:15 ` Mike Frysinger [this message]
2022-03-16 7:24 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjAExpWFfcGnNIeI@vapier \
--to=vapier@gentoo.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).