public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>
Cc: Joel Sherrill <joel@rtems.org>, newlib@sourceware.org
Subject: Re: [PATCH newlib] libc/include/malloc.h: Add prototype for GNU extension malloc_usable_size()
Date: Tue, 15 Mar 2022 16:36:28 -0400	[thread overview]
Message-ID: <YjD4zB5ajXrAuwae@vapier> (raw)
In-Reply-To: <f79bc06b-bc20-2c90-9e09-60c4f0855126@embedded-brains.de>

[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]

On 15 Mar 2022 19:42, Sebastian Huber wrote:
> On 15/03/2022 16:47, Mike Frysinger wrote:
> > On 15 Mar 2022 10:16, Joel Sherrill wrote:
> >> This is not provided by the newlib malloc implementation but may
> >> be available in external implementations.
> >> ---
> >>   newlib/libc/include/malloc.h | 4 ++++
> >>   1 file changed, 4 insertions(+)
> >>
> >> diff --git a/newlib/libc/include/malloc.h b/newlib/libc/include/malloc.h
> >> index a9dc5bca6..e73095e1e 100644
> >> --- a/newlib/libc/include/malloc.h
> >> +++ b/newlib/libc/include/malloc.h
> >> @@ -137,6 +137,10 @@ extern void __malloc_lock(struct _reent *);
> >>   
> >>   extern void __malloc_unlock(struct _reent *);
> >>   
> >> +#if __GNU_VISIBLE
> >> +extern size_t malloc_usable_size(void *);
> >> +#endif
> >> +
> > i'm confused.  isn't this prototype already defined in this header file
> > on line 101 above where you added this ?
> 
> Yes, and it is implemented by the Newlib malloc.

while true, we disable malloc in newlib for rtems:

newlib/configure.host:
# RTEMS supplies its own versions of some routines:
#       malloc()            (reentrant version)
#...
  *-*-rtems*)
    ...
    newlib_cflags="${newlib_cflags} ... -DMALLOC_PROVIDED ...

so i'm not sure what trouble Joel is running into.  maybe rtems also provides
its own malloc.h and that's what is missing this prototype.
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-03-15 21:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15 15:16 Joel Sherrill
     [not found] ` <BN2P110MB1544D6E89DF3E9BB09EC091D9A109@BN2P110MB1544.NAMP110.PROD.OUTLOOK.COM>
2022-03-15 15:38   ` C Howland
2022-03-15 15:44     ` Joel Sherrill
2022-03-15 15:54       ` C Howland
2022-03-15 15:47 ` Mike Frysinger
2022-03-15 18:42   ` Sebastian Huber
2022-03-15 20:36     ` Mike Frysinger [this message]
2022-03-15 21:14       ` Joel Sherrill
2022-03-15 20:54     ` Joel Sherrill
2022-03-15 23:50       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjD4zB5ajXrAuwae@vapier \
    --to=vapier@gentoo.org \
    --cc=joel@rtems.org \
    --cc=newlib@sourceware.org \
    --cc=sebastian.huber@embedded-brains.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).