public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Joel Sherrill <joel@rtems.org>
Cc: Sebastian Huber <sebastian.huber@embedded-brains.de>,
	Newlib <newlib@sourceware.org>
Subject: Re: [PATCH newlib] libc/include/malloc.h: Add prototype for GNU extension malloc_usable_size()
Date: Tue, 15 Mar 2022 19:50:08 -0400	[thread overview]
Message-ID: <YjEmME6YPuIzwPJj@vapier> (raw)
In-Reply-To: <CAF9ehCXF9DM7S7-HC4BkzagaL1HD1Dizx2+ACaTS=e2K06A6fA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

On 15 Mar 2022 15:54, Joel Sherrill wrote:
> The prototype isn't wrapped by __GNU_VISIBLE. Should it be?

we're talking about malloc.h here.  this is already a non-standard header.
the standard malloc APIs are defined in stdlib.h:
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/stdlib.h.html

so i'm not sure how much value there is annotating standards in a header
that is not in any standard, and whose inclusion clearly declares "i am
not conforming to any standards".

we could put a disclaimer/explanation at the top of the header file to
make this a bit more clear.
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2022-03-15 23:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15 15:16 Joel Sherrill
     [not found] ` <BN2P110MB1544D6E89DF3E9BB09EC091D9A109@BN2P110MB1544.NAMP110.PROD.OUTLOOK.COM>
2022-03-15 15:38   ` C Howland
2022-03-15 15:44     ` Joel Sherrill
2022-03-15 15:54       ` C Howland
2022-03-15 15:47 ` Mike Frysinger
2022-03-15 18:42   ` Sebastian Huber
2022-03-15 20:36     ` Mike Frysinger
2022-03-15 21:14       ` Joel Sherrill
2022-03-15 20:54     ` Joel Sherrill
2022-03-15 23:50       ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjEmME6YPuIzwPJj@vapier \
    --to=vapier@gentoo.org \
    --cc=joel@rtems.org \
    --cc=newlib@sourceware.org \
    --cc=sebastian.huber@embedded-brains.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).