From: Mike Frysinger <vapier@gentoo.org>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: Avoid using common symbols in v850 libgloss
Date: Sat, 19 Mar 2022 21:20:14 -0400 [thread overview]
Message-ID: <YjaBTtkfURhTh5Ts@vapier> (raw)
In-Reply-To: <c0cd56a5-db36-1bac-01d4-8b06d91a604e@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
On 09 Feb 2022 18:58, Jeff Law wrote:
> I've had this lying around for probably a year or two at this point.
> It just changes all the instance of "errno" from a common symbol to an
> extern. I can't offhand recall where the actual definition is, but it
> certainly exists in the generic code.
>
> --- a/libgloss/v850/_exit.c
> +++ b/libgloss/v850/_exit.c
> @@ -3,7 +3,7 @@
> #include <sys/stat.h>
> #include "sys/syscall.h"
>
> -int errno;
> +extern int errno;
why not just include errno.h ? using `extern int errno;` is so pre-2000 :p.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-03-20 1:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 1:58 Jeff Law
2022-02-10 15:03 ` Corinna Vinschen
2022-03-19 22:54 ` Brian Inglis
2022-03-19 23:57 ` Jeff Law
2022-03-20 1:20 ` Mike Frysinger [this message]
2022-03-20 5:07 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjaBTtkfURhTh5Ts@vapier \
--to=vapier@gentoo.org \
--cc=jeffreyalaw@gmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).