From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH v3 6/7] Optional struct _reent::_new::_unused
Date: Tue, 17 May 2022 14:49:05 +0200 [thread overview]
Message-ID: <YoOZwV0/sXH9oUuc@calimero.vinschen.de> (raw)
In-Reply-To: <e373d0a4-50ca-1608-887d-3b4b22787315@embedded-brains.de>
On May 16 17:58, Sebastian Huber wrote:
>
>
> On 16/05/2022 17:53, Sebastian Huber wrote:
> > diff --git a/newlib/libc/include/sys/reent.h b/newlib/libc/include/sys/reent.h
> > index 6d6796ed3..4b09e8cd5 100644
> > --- a/newlib/libc/include/sys/reent.h
> > +++ b/newlib/libc/include/sys/reent.h
> > @@ -685,6 +685,7 @@ struct _reent
> > _mbstate_t _wcsrtombs_state;
> > int _h_errno;
> > } _reent;
> > +#ifdef _REENT_BACKWARD_BINARY_COMPAT
> > /* Two next two fields were once used by malloc. They are no longer
> > used. They are used to preserve the space used before so as to
> > allow addition of new reent fields and keep binary compatibility. */
>
> I guess the comment could be also removed.
Yes.
>
> > @@ -693,7 +694,8 @@ struct _reent
> > #define _N_LISTS 30
> > unsigned char * _nextf[_N_LISTS];
> > unsigned int _nmalloc[_N_LISTS];
>
> Maybe we should also rename _nextf in _reserved_4 and _nmalloc in
> _reserved_5.
Right, that would be great. Feel free to push the patch with this change.
Thanks,
Corinna
next prev parent reply other threads:[~2022-05-17 12:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 15:53 [PATCH v3 0/7] Add --enable-newlib-reent-binary-compat configure option Sebastian Huber
2022-05-16 15:53 ` [PATCH v3 1/7] Add --enable-newlib-reent-binary-compat Sebastian Huber
2022-05-16 15:53 ` [PATCH v3 2/7] Cygwin: Enable backward binary compatibility Sebastian Huber
2022-05-16 15:53 ` [PATCH v3 3/7] Optional struct _reent::__unused_sdidinit Sebastian Huber
2022-05-16 15:53 ` [PATCH v3 4/7] Optional struct _reent::_unspecified_locale_info Sebastian Huber
2022-05-16 15:53 ` [PATCH v3 5/7] Optional struct _reent::_new::_reent::_unused_rand Sebastian Huber
2022-05-16 15:53 ` [PATCH v3 6/7] Optional struct _reent::_new::_unused Sebastian Huber
2022-05-16 15:58 ` Sebastian Huber
2022-05-17 12:49 ` Corinna Vinschen [this message]
2022-05-17 12:57 ` Sebastian Huber
2022-05-17 19:31 ` Corinna Vinschen
2022-05-24 21:25 ` Jeff Johnston
2022-05-16 15:53 ` [PATCH v3 7/7] Use global atexit data for all configurations Sebastian Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoOZwV0/sXH9oUuc@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).