From: Corinna Vinschen <vinschen@redhat.com>
To: Neal Frager <neal.frager@amd.com>
Cc: newlib@sourceware.org, cjwfirmware@vxmdesign.com,
jjohnstn@redhat.com, thomas.petazzoni@bootlin.com,
vapier@gentoo.org
Subject: Re: [PATCH v5 1/1] configure.ac: configurable tooldir install path
Date: Tue, 23 Jan 2024 09:53:30 +0100 [thread overview]
Message-ID: <Za9-iuMOLPUxdCFf@calimero.vinschen.de> (raw)
In-Reply-To: <20240111183019.121397-1-neal.frager@amd.com>
On Jan 11 18:30, Neal Frager wrote:
> This patch is required to fix how the newlib headers are installed
> when using a sysroot install directory.
>
> The cross compiler expects headers to be in
> .../host/usr/arm-none-eabi/sysroot/usr/include/newlib.h
> by default newlib installed the headers into
> .../host/usr/arm-none-eabi/sysroot/usr/arm-none-eabi/include/newlib.h
>
> ${exec_prefix} provides the .../host/usr/arm-none-eabi/sysroot path
> ${target_noncanonical} provides an extra arm-none-eabi/ that must be removed.
>
> With this patch, users can specify the tooldir path that is needed.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> Co-developed-by: Chris Wardman <cjwfirmware@vxmdesign.com>
> ---
> V1->V2:
> - migrated patch to configure.ac
> - changed option name to --with-tooldir=PATH
> V2->V3:
> - removed quotes around ${with_tooldir}
> V3->V4:
> - migrated case to AS_CASE
> - migrated AC_MSG_WARN to AC_MSG_ERROR
> V4->V5:
> - remove unnecessary with_tooldir clear when erroring out
> ---
> configure.ac | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index f1bb72100..0badf1d30 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2599,7 +2599,15 @@ esac
>
> # Some systems (e.g., one of the i386-aix systems the gas testers are
> # using) don't handle "\$" correctly, so don't use it here.
> -tooldir='${exec_prefix}'/${target_noncanonical}
> +AC_ARG_WITH([tooldir],
> + [AS_HELP_STRING([--with-tooldir=PATH],
> + [use given path to install target tools after build])],
> + [AS_CASE([x"$withval"],
> + [x/*],,
> + [AC_MSG_ERROR([argument to --with-tooldir must be an absolute path])])
> + ],
> + [with_tooldir='${exec_prefix}'/${target_noncanonical}])
> +tooldir=${with_tooldir}
> build_tooldir=${tooldir}
>
> # Create a .gdbinit file which runs the one in srcdir
> --
> 2.25.1
Pushed.
Thanks,
Corinna
prev parent reply other threads:[~2024-01-23 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 18:30 Neal Frager
2024-01-22 9:31 ` Frager, Neal
2024-01-22 13:12 ` Mike Frysinger
2024-01-23 8:53 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za9-iuMOLPUxdCFf@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=cjwfirmware@vxmdesign.com \
--cc=jjohnstn@redhat.com \
--cc=neal.frager@amd.com \
--cc=newlib@sourceware.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).