From: Corinna Vinschen <vinschen@redhat.com>
To: Dimitar Dimitrov <dimitar@dinux.eu>
Cc: newlib@sourceware.org
Subject: Re: [PATCH v4 1/2] libgloss: merge pru into top-level Makefile
Date: Tue, 23 Jan 2024 09:54:07 +0100 [thread overview]
Message-ID: <Za9-r_VY7xqSKixi@calimero.vinschen.de> (raw)
In-Reply-To: <20240122161136.4103003-1-dimitar@dinux.eu>
On Jan 22 18:11, Dimitar Dimitrov wrote:
> Avoid a recursive make to speed things up a bit. This change was
> inspired by the recent similar patch for c6x:
> https://sourceware.org/pipermail/newlib/2023/020869.html
>
> While at it, fork crt0-minrt.S into a separate source file instead of
> relying on a predefined macro to generate two different object files.
> This improves clarity, simplifies the build rules, and would allow
> further optimization in crt0-minrt.S to be implemented more cleanly.
>
> Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> ---
> Changes since v3:
> - Rebased.
>
> Changes since v2:
> - Rearrange Makefile.inc code chunks.
> - Whitespace fix.
>
> Changes since v1:
> - Retained copyright in pru/Makefile.inc.
> - Addec crt0*.s to libobjs_a_SOURCES.
> - Rebased.
>
> libgloss/Makefile.am | 3 +
> libgloss/configure.ac | 7 +-
> libgloss/pru/Makefile.in | 145 --------------------------------------
> libgloss/pru/Makefile.inc | 48 +++++++++++++
> libgloss/pru/crt0-minrt.S | 59 ++++++++++++++++
> libgloss/pru/crt0.S | 6 --
> 6 files changed, 113 insertions(+), 155 deletions(-)
> delete mode 100644 libgloss/pru/Makefile.in
> create mode 100644 libgloss/pru/Makefile.inc
> create mode 100644 libgloss/pru/crt0-minrt.S
Series pushed.
Thanks,
Corinna
prev parent reply other threads:[~2024-01-23 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 16:11 Dimitar Dimitrov
2024-01-22 16:11 ` [PATCH v4 2/2] libgloss: pru: Trim crt0-minrt.o Dimitar Dimitrov
2024-01-23 8:54 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za9-r_VY7xqSKixi@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=dimitar@dinux.eu \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).