From: Corinna Vinschen <vinschen@redhat.com>
To: Andrew Stubbs <ams@baylibre.com>
Cc: newlib@sourceware.org
Subject: Re: [PATCH] amdgcn: Implement proper locks
Date: Mon, 25 Mar 2024 11:35:19 +0100 [thread overview]
Message-ID: <ZgFTZ5ZeKYZ47u4A@calimero.vinschen.de> (raw)
In-Reply-To: <20240322145330.761851-1-ams@baylibre.com>
On Mar 22 14:53, Andrew Stubbs wrote:
> This should prevent printf output from multiple threads getting garbled.
>
> I don't know why IO ever worked properly -- probably it was always a bit
> broken -- but the GFX11 devices have a different cache architecture and
> trying to print from many threads at once corrupted the FILE buffers.
> ---
> newlib/Makefile.in | 24 ++-
> newlib/libc/sys/amdgcn/Makefile.inc | 3 +-
> newlib/libc/sys/amdgcn/include/sys/lock.h | 39 +++++
> newlib/libc/sys/amdgcn/lock.c | 187 ++++++++++++++++++++++
> 4 files changed, 250 insertions(+), 3 deletions(-)
> create mode 100644 newlib/libc/sys/amdgcn/include/sys/lock.h
> create mode 100644 newlib/libc/sys/amdgcn/lock.c
Pushed.
Thanks,
Corinna
next prev parent reply other threads:[~2024-03-25 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 14:53 Andrew Stubbs
2024-03-25 10:35 ` Corinna Vinschen [this message]
2024-04-04 14:05 ` amdgcn: Implement proper locks: Fix 'newlib/libc/sys/amdgcn/include/sys/lock.h' for C++ (was: [PATCH] amdgcn: Implement proper locks) Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgFTZ5ZeKYZ47u4A@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=ams@baylibre.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).