public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] libc/sys/rtems/include/machine/_types.h: Define daddr_t to be 64 bits for RTEMS
@ 2020-10-27 22:22 Joel Sherrill
  2020-10-28  6:43 ` Sebastian Huber
  0 siblings, 1 reply; 4+ messages in thread
From: Joel Sherrill @ 2020-10-27 22:22 UTC (permalink / raw)
  To: newlib

This type needs to be able to represent a position on a disk or
file system.
---
 newlib/libc/sys/rtems/include/machine/_types.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/newlib/libc/sys/rtems/include/machine/_types.h b/newlib/libc/sys/rtems/include/machine/_types.h
index 8e2d9a3ef..781142b7c 100644
--- a/newlib/libc/sys/rtems/include/machine/_types.h
+++ b/newlib/libc/sys/rtems/include/machine/_types.h
@@ -30,6 +30,9 @@ typedef	__uint64_t	_CLOCK_T_;
 typedef	int		_CLOCKID_T_;
 #define	__machine_clockid_t_defined
 
+typedef	__int64_t	daddr_t;
+#define __daddr_t_defined
+
 typedef	int		__accmode_t;	/* access permissions */
 typedef	__uint32_t	__fixpt_t;	/* fixed point number */
 typedef	int		__lwpid_t;	/* Thread ID (a.k.a. LWP) */
-- 
2.24.3


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] libc/sys/rtems/include/machine/_types.h: Define daddr_t to be 64 bits for RTEMS
  2020-10-27 22:22 [PATCH] libc/sys/rtems/include/machine/_types.h: Define daddr_t to be 64 bits for RTEMS Joel Sherrill
@ 2020-10-28  6:43 ` Sebastian Huber
  2020-10-28 14:53   ` Joel Sherrill
  0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Huber @ 2020-10-28  6:43 UTC (permalink / raw)
  To: Joel Sherrill, newlib

On 27/10/2020 23:22, Joel Sherrill wrote:

> This type needs to be able to represent a position on a disk or
> file system.
Looks good. Maybe add a \t after the #define to match the FreeBSD style 
of the file.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] libc/sys/rtems/include/machine/_types.h: Define daddr_t to be 64 bits for RTEMS
  2020-10-28  6:43 ` Sebastian Huber
@ 2020-10-28 14:53   ` Joel Sherrill
  2020-10-28 14:55     ` Sebastian Huber
  0 siblings, 1 reply; 4+ messages in thread
From: Joel Sherrill @ 2020-10-28 14:53 UTC (permalink / raw)
  To: Sebastian Huber; +Cc: Newlib

On Wed, Oct 28, 2020 at 1:43 AM Sebastian Huber <
sebastian.huber@embedded-brains.de> wrote:

> On 27/10/2020 23:22, Joel Sherrill wrote:
>
> > This type needs to be able to represent a position on a disk or
> > file system.
> Looks good. Maybe add a \t after the #define to match the FreeBSD style
> of the file.
>

Thanks. I pushed this to newlib and am waiting for the RTEMS github
mirror to pick it up before bumping our tools recipe.

--joel

>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber@embedded-brains.de
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] libc/sys/rtems/include/machine/_types.h: Define daddr_t to be 64 bits for RTEMS
  2020-10-28 14:53   ` Joel Sherrill
@ 2020-10-28 14:55     ` Sebastian Huber
  0 siblings, 0 replies; 4+ messages in thread
From: Sebastian Huber @ 2020-10-28 14:55 UTC (permalink / raw)
  To: joel; +Cc: Newlib

On 28/10/2020 15:53, Joel Sherrill wrote:

> On Wed, Oct 28, 2020 at 1:43 AM Sebastian Huber 
> <sebastian.huber@embedded-brains.de 
> <mailto:sebastian.huber@embedded-brains.de>> wrote:
>
>     On 27/10/2020 23:22, Joel Sherrill wrote:
>
>     > This type needs to be able to represent a position on a disk or
>     > file system.
>     Looks good. Maybe add a \t after the #define to match the FreeBSD
>     style
>     of the file.
>
>
> Thanks. I pushed this to newlib and am waiting for the RTEMS github
> mirror to pick it up before bumping our tools recipe.
I have a script to do this. I will update the RSB.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-10-28 14:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 22:22 [PATCH] libc/sys/rtems/include/machine/_types.h: Define daddr_t to be 64 bits for RTEMS Joel Sherrill
2020-10-28  6:43 ` Sebastian Huber
2020-10-28 14:53   ` Joel Sherrill
2020-10-28 14:55     ` Sebastian Huber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).