From: Brian Inglis <Brian.Inglis@SystematicSw.ab.ca>
To: newlib@sourceware.org
Subject: Re: arm fenv support - static inline of methods
Date: Wed, 13 May 2020 12:36:36 -0600 [thread overview]
Message-ID: <d5c3c018-e636-9d68-efee-92985e1c9fc8@SystematicSw.ab.ca> (raw)
In-Reply-To: <CAF9ehCWd4UCF3J_DMJZwrF3fb2VvSzF9HvR++zsAdXuKh2rf3Q@mail.gmail.com>
On 2020-05-13 12:22, Joel Sherrill wrote:
> On Wed, May 13, 2020 at 1:17 PM, Brian Inglis wrote:
>> On 2020-05-13 08:11, Joel Sherrill wrote:
>>> Eshan Dhawan is an RTEMS GSoC 2020 student working on adding more POSIX
>>> methods to RTEMS and newlib if appropriate. He is currently looking at
>>> adding more
>>> fenv.h implementations.
>>>
>>> The FreeBSD implementation of arm fenv.h has static inlines for all the
>>> methods in sys/fenv.h. Is this OK? Or should they be turned into real
>>> bodies in a C file?
>> Don't all functions need to be provided as linkable implementations for
>> cases where they are invoked using their address directly or indirectly,
>> unless the standards agree they don't need to be?
> That's what I think also but that's not how FreeBSD has implemented it.
> IMO the static inline implementations from them need to move to .c files.
I'm pretty sure I've seen somewhere in the sources, that the library has a
standard approach for doing this, as most libraries do for such common cases.
--
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in IEC units and prefixes, physical quantities in SI.]
next prev parent reply other threads:[~2020-05-13 18:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 14:11 Joel Sherrill
2020-05-13 18:17 ` Brian Inglis
2020-05-13 18:22 ` Joel Sherrill
2020-05-13 18:36 ` Brian Inglis [this message]
2020-05-13 19:14 ` Joel Sherrill
2020-05-13 21:03 ` Richard Damon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5c3c018-e636-9d68-efee-92985e1c9fc8@SystematicSw.ab.ca \
--to=brian.inglis@systematicsw.ab.ca \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).