From: jdoubleu <hi@jdoubleu.de>
To: newlib@sourceware.org
Subject: Re: [PATCH 2/2] tzset_r.c(_tzset_unlocked_r): POSIX angle bracket <> support
Date: Thu, 7 Apr 2022 17:48:38 +0200 [thread overview]
Message-ID: <fd4a1fdb-f66d-fdea-4004-785439d1ffa3@jdoubleu.de> (raw)
In-Reply-To: <20220405040358.18332-3-Brian.Inglis@SystematicSW.ab.ca>
Hi,
> + if (sscanf (tzenv, "%10[-+0-9A-Za-z]%n", __tzname_std, &n) <= 0
> + || n < TZNAME_MIN || TZNAME_MAX < n || '>' != tzenv[n])
during testing I noticed, that the condition `TZNAME_MAX < n` can never
be true. The format to sscanf explicitly parses 10 characters at maximum.
Longer input strings will be truncated. That is also the case with the
glibc implementation.
Cheers
---
🙎🏻♂️ jdoubleu
On 4/5/2022 6:03 AM, Brian Inglis wrote:
>
> local defines for POSIX minimum TZ abbr size 3 TZNAME_MIN and
> maximum TZ abbr size supported 10 TZNAME_MAX
> allow POSIX angle bracket < > quoted signed alphanumeric tz abbr e.g. <MESZ+0330>
> allow POSIX unquoted alphabetic tz abbr e.g. MESZ
> allow same suuport for DST tz abbr
> ---
> newlib/libc/time/tzset_r.c | 67 +++++++++++++++++++++++++++++++-------
> 1 file changed, 55 insertions(+), 12 deletions(-)
>
next prev parent reply other threads:[~2022-04-07 15:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 4:03 [PATCH 0/2] add tzset/_r POSIX angle bracket <> support in TZ env var Brian Inglis
2022-04-05 4:03 ` [PATCH 1/2] tzset.c: doc update POSIX angle bracket <> support Brian Inglis
2022-04-05 4:03 ` [PATCH 2/2] tzset_r.c(_tzset_unlocked_r): " Brian Inglis
2022-04-07 9:56 ` jdoubleu
2022-04-07 16:07 ` Brian Inglis
2022-04-07 16:18 ` jdoubleu
2022-04-07 15:48 ` jdoubleu [this message]
2022-04-07 21:35 ` Jeff Johnston
2022-04-07 23:36 ` Brian Inglis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd4a1fdb-f66d-fdea-4004-785439d1ffa3@jdoubleu.de \
--to=hi@jdoubleu.de \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).