Re: [PATCH 2/2] tzset_r.c(_tzset_unlocked_r): POSIX angle bracket <> support

[jdoubleu <hi@jdoubleu.de>]

Hi Brian

> +#include <limits.h>	/* {,_POSIX_}TZNAME_MAX */
> ... > +#define TZNAME_MIN	3	/* POSIX min TZ abbr size local def */
> +#define TZNAME_MAX	10	/* POSIX max TZ abbr size local def */

The comment suggests, that `TZNAME_MAX` is coming from `limits.h`, isn't it?

Everything else looks good to me.

Unfortunately, I wasn't able to test these changes, yet. I cannot easily 
build newlib for my project. However, I've prepared some tests vectors 
(see 
https://github.com/jdoubleu/newlib-posix-tzset-tests/blob/main/timezones.h), 
which I plan to integrate with the newlib testsuite.

Cheers
---
🙎🏻‍♂️ jdoubleu
On 4/5/2022 6:03 AM, Brian Inglis wrote:
> 
> local defines for POSIX minimum TZ abbr size 3 TZNAME_MIN and
> maximum TZ abbr size supported 10 TZNAME_MAX
> allow POSIX angle bracket < > quoted signed alphanumeric tz abbr e.g. <MESZ+0330>
> allow POSIX unquoted alphabetic tz abbr e.g. MESZ
> allow same suuport for DST tz abbr
> ---
>   newlib/libc/time/tzset_r.c | 67 +++++++++++++++++++++++++++++++-------
>   1 file changed, 55 insertions(+), 12 deletions(-)
>