[Bug Infrastructure/30042] patchworks should automatically notice a pushed patch

["carlos at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30042

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carlos at redhat dot com

--- Comment #1 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Tom Tromey from comment #0)
> Consider this patch:
> 
> https://patchwork.sourceware.org/project/gdb/patch/20230122212801.1926063-1-
> tom@tromey.com/
> 
> I used git send-email to send this patch and patchworks dutifully
> logged it.  Then I pushed the patch -- but patchworks did nothing,
> I had to go into the web interface to explicitly mark it as committed.
> 
> I think patchworks ought to notice this situation.

This is easier said than done unfortunately.

(1) Out of the box feature.

This is not functionality that patchwork provides.

I would be an RFE for patchwork upstream
(https://github.com/getpatchwork/patchwork/).

(2) Commit cleanup script.

Alternatively, in glibc we run a script to compare commits against patchwork
patches and close those that have been committed.

The first problem we saw here was that it requires discipline from the
community to commit *exactly* what was posted and agreed upon in order to make
the checking less error prone.

In glibc we have adopted a stronger policy that you should only commit what the
author provided, or ask the author to change it. My own opinion is that it is
disrespectful to change what the author is submitting.

The only allowed changes are additions of Reviewed-by, Tested-by tags in the
commit message.

In either (1) or (2) I think this is up to the projects to run the scripts that
they need.

-- 
You are receiving this mail because:
You are the assignee for the bug.