From: "carlos at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: overseers@sourceware.org
Subject: [Bug Infrastructure/30042] patchworks should automatically notice a pushed patch
Date: Tue, 24 Jan 2023 15:02:59 +0000 [thread overview]
Message-ID: <bug-30042-14326-oSlTM1ECBl@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30042-14326@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=30042
Carlos O'Donell <carlos at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |carlos at redhat dot com
--- Comment #1 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Tom Tromey from comment #0)
> Consider this patch:
>
> https://patchwork.sourceware.org/project/gdb/patch/20230122212801.1926063-1-
> tom@tromey.com/
>
> I used git send-email to send this patch and patchworks dutifully
> logged it. Then I pushed the patch -- but patchworks did nothing,
> I had to go into the web interface to explicitly mark it as committed.
>
> I think patchworks ought to notice this situation.
This is easier said than done unfortunately.
(1) Out of the box feature.
This is not functionality that patchwork provides.
I would be an RFE for patchwork upstream
(https://github.com/getpatchwork/patchwork/).
(2) Commit cleanup script.
Alternatively, in glibc we run a script to compare commits against patchwork
patches and close those that have been committed.
The first problem we saw here was that it requires discipline from the
community to commit *exactly* what was posted and agreed upon in order to make
the checking less error prone.
In glibc we have adopted a stronger policy that you should only commit what the
author provided, or ask the author to change it. My own opinion is that it is
disrespectful to change what the author is submitting.
The only allowed changes are additions of Reviewed-by, Tested-by tags in the
commit message.
In either (1) or (2) I think this is up to the projects to run the scripts that
they need.
--
You are receiving this mail because:
You are the assignee for the bug.
next prev parent reply other threads:[~2023-01-24 15:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 14:29 [Bug Infrastructure/30042] New: " tromey at sourceware dot org
2023-01-24 15:02 ` carlos at redhat dot com [this message]
2023-01-24 15:32 ` [Bug Infrastructure/30042] " siddhesh at sourceware dot org
2023-01-24 21:55 ` tromey at sourceware dot org
2023-01-24 22:07 ` mark at klomp dot org
2023-01-25 17:22 ` siddhesh at sourceware dot org
2023-01-25 20:23 ` tromey at sourceware dot org
2023-01-30 14:19 ` pedro at palves dot net
2024-03-24 22:02 ` mark at klomp dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-30042-14326-oSlTM1ECBl@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=overseers@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).