Failing to build with the core patch.

Failing to build with the core patch.

[Alexandre Petit-Bianco]

Anthony, 

I'm (eventually) testing your patch. I'm trying to build your proposed
extension of libjava and it fails with:

/bin/sh ./libtool --tag=GCJ --mode=link /castro/street/apbianco/t/build/gcc/gcc/gcj -B/castro/street/apbianco/t/build/gcc/alphaev6-unknown-linux-gnu/libjava/ -B/castro/street/apbianco/t/build/gcc/gcc/ -L/castro/street/apbianco/t/build/gcc/alphaev6-unknown-linux-gnu/libjava -mieee -g -O2  -o jv-convert --main=gnu.gcj.convert.Convert -rpath /castro/street/apbianco/t/install/lib -shared-libgcc  gnu/gcj/convert/BytesToUnicode.lo gnu/gcj/convert/Convert.lo gnu/gcj/convert/Input_8859_1.lo gnu/gcj/convert/Input_ASCII.lo gnu/gcj/convert/Input_EUCJIS.lo gnu/gcj/convert/Input_JavaSrc.lo gnu/gcj/convert/Input_SJIS.lo gnu/gcj/convert/Input_UTF8.lo gnu/gcj/convert/Input_iconv.lo gnu/gcj/convert/IOConverter.lo gnu/gcj/convert/Output_8859_1.lo gnu/gcj/convert/Output_ASCII.lo gnu/gcj/convert/Output_EUCJIS.lo gnu/gcj/convert/Output_JavaSrc.lo gnu/gcj/convert/Output_SJIS.lo gnu/gcj/convert/Output_UTF8.lo gnu/gcj/convert/Output_iconv.lo gnu/gcj/convert/UnicodeToBytes.lo libgcj.la ./../boehm-gc/l!
ibgcjgc.la -L/castro/street/apbianco/t/build/gcc/alphaev6-unknown-linux-gnu/libjava/../boehm-gc/.libs -lpthread ./../zlib/libzgcj.la -L/castro/street/apbianco/t/build/gcc/alphaev6-unknown-linux-gnu/libjava/../zlib/.libs -L/castro/street/apbianco/t/build/gcc/alphaev6-unknown-linux-gnu/libjava/.libs 
/castro/street/apbianco/t/build/gcc/gcc/gcj -B/castro/street/apbianco/t/build/gcc/alphaev6-unknown-linux-gnu/libjava/ -B/castro/street/apbianco/t/build/gcc/gcc/ -mieee -g -O2 -o .libs/jv-convert --main=gnu.gcj.convert.Convert -shared-libgcc gnu/gcj/convert/.libs/BytesToUnicode.o gnu/gcj/convert/.libs/Convert.o gnu/gcj/convert/.libs/Input_8859_1.o gnu/gcj/convert/.libs/Input_ASCII.o gnu/gcj/convert/.libs/Input_EUCJIS.o gnu/gcj/convert/.libs/Input_JavaSrc.o gnu/gcj/convert/.libs/Input_SJIS.o gnu/gcj/convert/.libs/Input_UTF8.o gnu/gcj/convert/.libs/Input_iconv.o gnu/gcj/convert/.libs/IOConverter.o gnu/gcj/convert/.libs/Output_8859_1.o gnu/gcj/convert/.libs/Output_ASCII.o gnu/gcj/convert/.libs/Output_EUCJIS.o gnu/gcj/convert/.libs/Output_JavaSrc.o gnu/gcj/convert/.libs/Output_SJIS.o gnu/gcj/convert/.libs/Output_UTF8.o gnu/gcj/convert/.libs/Output_iconv.o gnu/gcj/convert/.libs/UnicodeToBytes.o  -L/castro/street/apbianco/t/build/gcc/alphaev6-unknown-linux-gnu/libjava ./.libs/libgcj.!
so -ldl ./../boehm-gc/.libs/libgcjgc.so -L/castro/street/apbianco/t/build/gcc/alphaev6-unknown-linux-gnu/libjava/../boehm-gc/.libs -lpthread ./../zlib/.libs/libzgcj.so -L/castro/street/apbianco/t/build/gcc/alphaev6-unknown-linux-gnu/libjava/../zlib/.libs -L/castro/street/apbianco/t/build/gcc/alphaev6-unknown-linux-gnu/libjava/.libs -Wl,--rpath -Wl,/castro/street/apbianco/t/install/lib
./.libs/libgcj.so: undefined reference to `gnu::gcj::Core::create(java::lang::String*)'
./.libs/libgcj.so: undefined reference to `gnu::gcj::protocol::core::CoreInputStream::unsafeGetByte(long long)'
./.libs/libgcj.so: undefined reference to `gnu::gcj::protocol::core::CoreInputStream::copyIntoByteArray(JArray<char>*, int, int)'
collect2: ld returned 1 exit status
make[1]: *** [jv-convert] Error 1
make[1]: Leaving directory `/castro/street/apbianco/t/build/gcc/alphaev6-unknown-linux-gnu/libjava'
make: *** [all-recursive] Error 1

(I'm building on Alpha/linux.) The Makefile{,am,in} appears to be OK,
listing gnu/gcj/protocol/core/natCoreInputStream.cc and such but it
never seems to build. If I touch an other new file, such as
gnu/gcj/natCore.cc, then natCore.cc gets rebuild.

Am I missing something?

./A

Re: Failing to build with the core patch.

[Anthony Green]

Alex wrote:
> (I'm building on Alpha/linux.) The Makefile{,am,in} appears to be OK,
> listing gnu/gcj/protocol/core/natCoreInputStream.cc and such but it
> never seems to build. If I touch an other new file, such as
> gnu/gcj/natCore.cc, then natCore.cc gets rebuild.
> 
> Am I missing something?

Hmm... let me poke about in your tree on castro.

AG

Re: Failing to build with the core patch.

[Anthony Green]

Alex wrote:
> Am I missing something?

My patch didn't include the Makefile.in changes (too boring), and it looks
like your Makefile.in wasn't rebuilt correctly.  Do you have the proper
automake?

Specifically, automake is supposed to arrange for natCore.lo to appear in
libgcj_la_OBJECTS , and it's not there.  Same for the other missing nat* file.

AG

Re: Failing to build with the core patch.

[Alexandre Petit-Bianco]

Anthony Green writes:

> My patch didn't include the Makefile.in changes (too boring), and it
> looks like your Makefile.in wasn't rebuilt correctly.  Do you have
> the proper automake?

1.5? No.

> Specifically, automake is supposed to arrange for natCore.lo to
> appear in libgcj_la_OBJECTS , and it's not there.  Same for the
> other missing nat* file.

Ha. BTW, I can reproduce the error on x86 as well. Should I just use
automake 1.5?

./A

Re: Failing to build with the core patch.

[Anthony Green]

Alex wrote:
> Ha. BTW, I can reproduce the error on x86 as well. Should I just use
> automake 1.5?

No, we're not using 1.5 for libgcj (although rhug _is_ using 1.5).

libgcj uses this version:

    ftp://sources.redhat.com/pub/java/automake-gcj-1.4.tar.gz

AG

Re: Failing to build with the core patch.

[Alexandre Petit-Bianco]

Anthony Green writes:

>     ftp://sources.redhat.com/pub/java/automake-gcj-1.4.tar.gz

OK. libgcj and your patch (and others) just built. It's a serious
patch (xerces build error) that I want to try on rhug. Yes, I'm
thinking about reviewing your compiler patch too.

./A

Re: Failing to build with the core patch.

[Anthony Green]

Alex wrote:
> OK. libgcj and your patch (and others) just built. It's a serious
> patch (xerces build error) that I want to try on rhug. Yes, I'm
> thinking about reviewing your compiler patch too.

I forgot to mention something important... you should remove this part of my
patch from lang_specific_driver...

+   while (*ptr)
+     {
+       if (*ptr == '.')
+ *ptr = '/';
+       ptr++;
+     }

This only impacts any files you built with "gcj -R", so there's no need to
rebuild libgcj, and there are only 3 files in xerces like this...

lib_org_apache_xerces_la_DEPENDENCIES = mprops.o mprops_fr.o mprops_ja.o

Thanks!

AG