public inbox for sid@sourceware.org
 help / color / mirror / Atom feed
From: matthew green <mrg@cygnus.com>
To: Ben Elliston <bje@redhat.com>
Cc: sid@sources.redhat.com
Subject: re: RFA: gloss component extensions
Date: Sun, 07 Jan 2001 20:30:00 -0000	[thread overview]
Message-ID: <1166.978928176@cygnus.com> (raw)
In-Reply-To: <Pine.LNX.4.31.0101081350310.27879-100000@moshpit.cygnus.com>

   
         In the case of missing gettimeofday() and times() functions, the newlib stub
         functions should set ENOSYS.  Do they use the -1 to detect this?
   
      ah, i should probably also add a call:
      	set_error_result(newlib::eNoSys);
      then?
   
   Yes.

OK, i have commited the following.  thanks.


2001-01-08  matthew green  <mrg@redhat.com>

	* gloss.cxx (do_sys_times): Set error value as well as return value
	if times() does not exist on the host.
	(do_sys_gettimeofday): Set error value as well as return value
	if gettimeofday() does not exist on the host.


Index: gloss.cxx
===================================================================
RCS file: /cvs/src/src/sid/component/gloss/gloss.cxx,v
retrieving revision 1.2
diff -p -r1.2 gloss.cxx
*** gloss.cxx	2001/01/07 04:51:31	1.2
--- gloss.cxx	2001/01/08 04:28:21
*************** gloss32::do_sys_gettimeofday()
*** 632,637 ****
--- 632,638 ----
    set_int_result(rv);
  #else
    set_int_result(-1);
+   set_error_result(newlib::eNoSys);
  #endif
  }
  
*************** gloss32::do_sys_times()
*** 663,668 ****
--- 664,670 ----
    set_int_result(rv);
  #else
    set_int_result(-1);
+   set_error_result(newlib::eNoSys);
  #endif
  }
  

      reply	other threads:[~2001-01-07 20:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-06 18:59 matthew green
2001-01-07 18:03 ` Ben Elliston
2001-01-07 18:38   ` matthew green
2001-01-07 18:51     ` Ben Elliston
2001-01-07 20:30       ` matthew green [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1166.978928176@cygnus.com \
    --to=mrg@cygnus.com \
    --cc=bje@redhat.com \
    --cc=sid@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).