public inbox for sid@sourceware.org
 help / color / mirror / Atom feed
From: Ben Elliston <bje@redhat.com>
To: matthew green <mrg@cygnus.com>
Cc: <sid@sources.redhat.com>
Subject: Re: RFA: gloss component extensions
Date: Sun, 07 Jan 2001 18:03:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.31.0101081253570.27669-100000@moshpit.cygnus.com> (raw)
In-Reply-To: <2138.978836327@cygnus.com>

mrg wrote:

   time() syscall (it did not fill in it's argument, just returned the
   time), and fix the open() flags to match what newlib uses.

Before you commit, I have some questions:

   2000-12-30  matthew green  <mrg@redhat.com>

   	* gloss.cxx (do_sys_time): New function.
   	(do_sys_times): Likewise.
   	(do_sys_gettimeofday): Likewise.
   	(syscall_trap): Call do_sys_time().  Call new do_sys_times() and
   	do_sys_gettimeofday() for times() and .

`And ..' .. what?

   + #else
   +   set_int_result(-1);
   + #endif

In the case of missing gettimeofday() and times() functions, the newlib stub
functions should set ENOSYS.  Do they use the -1 to detect this?

Other than that, the only thing missing is your test cases to prove that
these work.

Ben

  reply	other threads:[~2001-01-07 18:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-06 18:59 matthew green
2001-01-07 18:03 ` Ben Elliston [this message]
2001-01-07 18:38   ` matthew green
2001-01-07 18:51     ` Ben Elliston
2001-01-07 20:30       ` matthew green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.31.0101081253570.27669-100000@moshpit.cygnus.com \
    --to=bje@redhat.com \
    --cc=mrg@cygnus.com \
    --cc=sid@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).