64-bit buglet

64-bit buglet

[Richard Henderson]

I need the following to build sid on an Alpha.  This issue
is that the two arguments to std::min must be the same type,
otherwise the template does not match.

Ok?


r~


Index: sid/component/gloss/gloss.cxx
===================================================================
RCS file: /cvs/cvsfiles/devo/sid/component/gloss/gloss.cxx,v
retrieving revision 1.32
diff -c -p -d -r1.32 gloss.cxx
*** gloss.cxx	2001/08/03 06:01:00	1.32
--- gloss.cxx	2001/08/12 18:02:20
*************** gloss32::read (int fd, address32 addr, s
*** 1029,1035 ****
  
  	  if (rx_buffer.size() > 0)
  	    {
! 	      count_read = std::min (len, rx_buffer.size());
  	      for (int i = 0; i < count_read; ++i)
  		{
  		  c = rx_buffer.front();
--- 1029,1035 ----
  
  	  if (rx_buffer.size() > 0)
  	    {
! 	      count_read = std::min (size_t(len), rx_buffer.size());
  	      for (int i = 0; i < count_read; ++i)
  		{
  		  c = rx_buffer.front();

Re: 64-bit buglet

[Ben Elliston]

>>>>> "Richard" == Richard Henderson <rth@redhat.com> writes:

  Richard> I need the following to build sid on an Alpha.  This issue
  Richard> is that the two arguments to std::min must be the same type,
  Richard> otherwise the template does not match.

It would probably be better to use static_cast<size_t> (len) instead
for consistency with the rest of the source tree.  Otherwise, commit
away.

Ben