public inbox for sid@sourceware.org
 help / color / mirror / Atom feed
From: Doug Evans <dje@transmeta.com>
To: Jim Blandy <jimb@redhat.com>
Cc: sid@sources.redhat.com, cgen@sources.redhat.com
Subject: sid cgen cpus broken by absence of pic libiberty
Date: Wed, 02 Feb 2005 08:41:00 -0000	[thread overview]
Message-ID: <16896.37397.804541.303224@casey.transmeta.com> (raw)
In-Reply-To: <vt28y67phl6.fsf@zenia.home>

Jim Blandy writes:
 > *************** cgen_parse_keyword (CGEN_CPU_DESC cd ATT
 > *** 216,222 ****
 >     /* Allow letters, digits, and any special characters.  */
 >     while (((p - start) < (int) sizeof (buf))
 >   	 && *p
 > ! 	 && (ISALNUM (*p)
 >   	     || *p == '_'
 >   	     || strchr (keyword_table->nonalpha_chars, *p)))
 >       ++p;
 > --- 216,224 ----
 >     /* Allow letters, digits, and any special characters.  */
 >     while (((p - start) < (int) sizeof (buf))
 >   	 && *p
 > ! 	 && (('a' <= *p && *p <= 'z')
 > !              || ('A' <= *p && *p <= 'Z')
 > !              || ('0' <= *p && *p <= '9')
 >   	     || *p == '_'
 >   	     || strchr (keyword_table->nonalpha_chars, *p)))
 >       ++p;
 > 
 > Does that sound reasonable (well, reasonable with a clothespin on the
 > nose) to folks?

Well, I'd still tuck the code away in macro or whatever.
Or, use just plain ctype.  This is just one example so
who knows what libiberty actually brings to the party
in all the affected cases though.

Seems pretty sad though, eh?

Maybe the thing to do is create one's own mini-libiberty
that one controls and so isn't sacked with the politics or
whatever of binutils.  Keeping the naming close to libiberty
would allow an easier transition back to libiberty if such
a day arrives.

  reply	other threads:[~2005-02-02  8:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-02  7:13 Jim Blandy
2005-02-02  8:41 ` Doug Evans [this message]
2005-02-02 11:18 ` Frank Ch. Eigler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16896.37397.804541.303224@casey.transmeta.com \
    --to=dje@transmeta.com \
    --cc=cgen@sources.redhat.com \
    --cc=jimb@redhat.com \
    --cc=sid@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).